New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-fwk01 replace fullname() with name() in creating TGEO geometry #27311
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27311/10540
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Fireworks/Geometry @cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped) |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Get rid of the namespace in volume declaration for translating DDD geometry.
PR validation:
Tested by using the TGEO to VecGeom interface to test GeantV geometry. Could not find application requiring the namespace
if this PR is a backport please specify the original PR:
Nothing special