Remove UBSAN flags from CondFormats/HcalObjects

[Dr15Jones]

PR description:

CondFormats/HcalObjects directly uses boost serialization which is known to cause problems when compiled with UBSAN.

PR validation:

The code now compiles and links using CMSSW_11_0_UBSAN_X_2019-06-21-2300 IB. Previously we were getting a segmentation fault during the edmCheckClassVersion call.

[Dr15Jones]

This is related to #26669

[cmsbuild]

The code-checks are being triggered in jenkins.

[Dr15Jones]

@smuzaffar I had to directly use REM_CXXFLAGS instead of being able to say 'exclude from UBSAN'. Is this how you ultimately want to handle this case?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27312/10541

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CondFormats/HcalObjects

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1110/console Started: 2019/06/22 13:01

[Dr15Jones]

Note, this is the only package that directly uses boost serialization. Is this how the db L2's want this to be?

[cmsbuild]

+1
Tested at: 3c31fa1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-085790/1110/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Prevent pLHE workflows to start from input files  #27285 @fabiocos: Prevent pLHE workflows to start from input files
• HGCal trigger support for Fireworks #27304 @Mourtz: HGCal trigger support for Fireworks

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-085790/1110/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-085790/1110/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-085790/1110/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3254598
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3254263
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[smuzaffar]

@Dr15Jones , you do not need to do this. SCRAM now does not pass UBSAN flags when boost serialization file (Serialization.cc) is compiled.

[Dr15Jones]

@smuzaffar This case is different. For the rest of the CondFormats packages, they are only indirectly dependent on boost serialization. That is, the code in the package itself does not depend on boost serialization, it is only the autogenerated Serialization.cc file which has the dependency.

CondFormats/HcalObjects is different. The source code in the package itself directly calls boost serialization macros. Under UBSAN those macros are causing segmentation faults when running edmCheckClassVersion (which is what was also happening to the other packages because of Serialization.cc). So for this case we need to explicitly stop UBSAN from compiling the package source directly.

[smuzaffar]

@Dr15Jones , in this case then please use

<ifrelease name="_UBSAN_">
  <flags   REM_CXXFLAGS="-fno-omit-frame-pointer -fsanitize=undefined"/>
</ifrelease>

[cmsbuild]

Pull request #27312 was updated. @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @ggovi, @pohsun can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1126/console Started: 2019/06/24 06:43

[cmsbuild]

+1
Tested at: 8907c42
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-085790/1126/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-085790/1126/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3254598
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3254261
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[fabiocos]

@ggovi @christopheralanwest @tocheng could you please check?

[ggovi]

+1

[pohsun]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1