Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2021 global tags to include new pixel conditions #27334

Merged
merged 3 commits into from Jun 27, 2019

Conversation

christopheralanwest
Copy link
Contributor

PR description:

As agreed at #27183 (comment), this PR introduces two global tag updates to autoCond for 2021 conditions. To simplify comparisons, PR #27183 only introduced the 2021 conditions needed for that PR. This PR adds the remaining two 2021 conditions for the following global tags:

106X_upgrade2021_realistic_v8:

Difference with respect to previous auto:phase1_2021_realistic GT:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2021_realistic_v8/106X_upgrade2021_realistic_v7
Difference with respect to candidate GT in PR #27183:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2021_realistic_v8/106X_upgrade2021_realistic_Candidate_2019_06_17_18_50_50
(The difference in GBRDWrapperRcd conditions is irrelevant for 2021 scenarios.)

106X_upgrade2021cosmics_realistic_deco_v3:

Difference with respect to previous auto:phase1_2021_cosmics GT:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2021cosmics_realistic_deco_v3/106X_upgrade2021cosmics_realistic_deco_v2
Difference with respect to candidate GT in PR #27183:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2021cosmics_realistic_deco_v3/106X_upgrade2021cosmics_realistic_deco_Candidate_2019_06_17_19_08_59

The PR first cherry-picks the GT commit from PR #27183 so that this PR can be merged as soon as #27183 is merged without generating conflicts.

A backport PR will be prepared.

PR validation:

Tested with runTheMatrix.py -l 11624.0.

if this PR is a backport please specify the original PR:

A backport PR will be prepared.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27334/10575

  • This PR adds an extra 12KB to repository

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1138/console Started: 2019/06/24 21:38

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab3fe0/1138/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2139 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3254598
  • DQMHistoTests: Total failures: 4447
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3249817
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab3fe0/1156/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2131 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3254598
  • DQMHistoTests: Total failures: 4501
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3249763
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1159/console Started: 2019/06/25 22:17

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab3fe0/1159/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 898 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3254598
  • DQMHistoTests: Total failures: 1225
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3253039
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

  • Changes introduced only in 2021 workflow 11624.0 and only in pixel or pixel-dependent plots, as expected
  • Tags have been validated offline by pixel experts (for example, https://indico.cern.ch/event/824860/#19-tracker-preparation-for-end) and are already in use in production of relvals that use the 106X_mcRun3_2021_realistic_v1 global tag

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bced981 into cms-sw:master Jun 27, 2019
@christopheralanwest christopheralanwest deleted the alca-gt-for-pr27183 branch August 21, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants