Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override the default value of the input file for wf 250203.18 #27336

Merged
merged 1 commit into from Jun 26, 2019

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Jun 25, 2019

PR description:

Override the default value of the input file for wf 250203.18 to solve the persistent DAS error in IB after #27206 .

PR validation:

Until the files are cached at CERN the wf will not work out of the box, but the correct query string is produced:

10:07 cmsdev25 661> cat cmdLog 

# in: /build/fabiocos/110X/crash/CMSSW_11_0_X_2019-06-24-1100/work going to execute cd 250203.18_H125GGgluonfusion_13UP18+H125GGgluonfusion_13UP18INPUT+DIGIPRMXUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25
 dasgoclient --limit 0 --query 'file dataset=/RelValH125GGgluonfusion_13/CMSSW_10_6_0-106X_upgrade2018_realistic_v4-v2/GEN-SIM site=T2_CH_CERN' | sort -u > step1_dasquery.log  2>&1
 

and

10:07 cmsdev25 662> dasgoclient --limit 0 --query 'file dataset=/RelValH125GGgluonfusion_13/CMSSW_10_6_0-106X_upgrade2018_realistic_v4-v2/GEN-SIM'
/store/relval/CMSSW_10_6_0/RelValH125GGgluonfusion_13/GEN-SIM/106X_upgrade2018_realistic_v4-v2/10000/B9F429B4-1EC9-A049-B70F-0F53757926FA.root
/store/relval/CMSSW_10_6_0/RelValH125GGgluonfusion_13/GEN-SIM/106X_upgrade2018_realistic_v4-v2/10000/2C8B55AC-9316-8844-970B-653596580104.root

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27336/10585

  • This PR adds an extra 44KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1145/console Started: 2019/06/25 10:25

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6aef3f/1145/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3254598
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3254262
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@prebello
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor Author

@kpedro88 please have a look, this is not upgrade specific, I would like to get it inside and finally fix these failing tests

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor Author

+1

@cmsbuild cmsbuild merged commit bb6fb56 into cms-sw:master Jun 26, 2019
@fabiocos fabiocos deleted the fc-fix250203dot18 branch August 7, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants