[HGCal] Updating HGCalValidator with SimHits, Digis, RecHits and MultiClusters

[apsallid]

PR description:

This PR updates the HGCalValidator package to be able to handle:

1. SimHits, Digis, RecHits (@tmengke, @deguio, @skunori)

As part of the Validation of campaigns regularly announced from PdmV and UPSG, we want to monitor and validate SimHits, Digis and Rechits objects. Usually, RelMon and DQM GUI is being used for this task. However, in order to quantify the performance of certain clustering algorithms or optimizing the same algorithm or checking different calibration algorithms or inspect the plots in the DQM file easier, we include in our webpage results from the above mentioned objects.

@bsunanda: This slightly touches the HGCalSimHitValidation.cc, HGCalDigiValidation.cc, HGCalRecHitValidation.cc by adding a zero to the names of the DQM histograms, so the results in our web page to be ordered by layer number.

2. Multiclusters (@rovere, @felicepantaleo, @apsallid, @amartelli)

With the inclusion of TICL multiclusters in CMSSW being imminent, we update the HGCalValidator package with the capability of monitoring as well as associating MultiClusters wiith CaloParticles. In the HGCal webpage [1] there is a "Validation" section where we document and describe all the relevant plots. This is a first work based on the standard "hgcalMultiClusters" object that if needed will be refined in the very near future with the study of the TICL multiclusters.

PR validation:

We tested locally that all objects plots are populated [2-4] and will continue the validation of the code as soon as TICL multiclusters are available.

if this PR is a backport please specify the original PR:

Not a backport.

[1] http://hgcal.web.cern.ch/hgcal/

[2] http://tmengke.web.cern.ch/tmengke/HGCHitValidation_front/

[3] http://apsallid.web.cern.ch/apsallid/HGCValidmulticlusters_testing/

[4] http://apsallid.web.cern.ch/apsallid/HGCValidlayerclusters_testing/

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27337/10589

• This PR adds an extra 188KB to repository

[cmsbuild]

A new Pull Request was created by @apsallid for master.

It involves the following packages:

Validation/HGCalValidation

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @rovere, @lgray, @cseez, @bsunanda, @pfs, @kpedro88 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1148/console Started: 2019/06/25 14:34

[cmsbuild]

+1
Tested at: a0a3995
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce8454/1148/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce8454/1148/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3253034
• DQMHistoTests: Total failures: 8217
• DQMHistoTests: Total nulls: 1648
• DQMHistoTests: Total successes: 3242835
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -31861.573 KiB( 32 files compared)
• DQMHistoSizes: changed ( 27434.0,... ): -8045.767 KiB HGCAL/HGCalValidator
• DQMHistoSizes: changed ( 27434.0,... ): 0.111 KiB HGCAL/HGCalSimHitsV
• DQMHistoSizes: changed ( 27434.0,... ): 0.111 KiB HGCAL/HGCalDigisV
• DQMHistoSizes: changed ( 27434.0,... ): 0.093 KiB HGCAL/HGCalRecHitsV
• DQMHistoSizes: changed ( 29034.0 ): -7725.802 KiB HGCAL/HGCalValidator
• DQMHistoSizes: changed ( 20034.0,... ): 0.158 KiB HGCAL/HGCalSimHitsV
• DQMHistoSizes: changed ( 20034.0,... ): 0.158 KiB HGCAL/HGCalDigisV
• DQMHistoSizes: changed ( 20034.0,... ): 0.132 KiB HGCAL/HGCalRecHitsV
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[jfernan2]

@apsallid You did an exhaustive validation of this PR, thank you!!
Could you please do a last check to see if everything looks as expected from the point of view of DQM GUI?
These are the differences spotted by the Bin by Bin tool, any phase2 workflow at the bottom shows the histograms removed and those added now (Please bear in mind that the number of 2D histos you are handling is huge and the rendering may take a while in the DQM GUI):
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_0_X_2019-06-24-2300+ce8454/32405/dqm-histo-comparison-summary.html

[apsallid]

Hi @jfernan2 ,
I checked and indeed I see the extra histos we added. To me it looks ok. There will be a
meticulous recheck of the package when we will have the TICL multiclusters for sure.

[jfernan2]

+1
Thanks @apsallid I understand these hundreds of new histos are placed there to check in case of problems in a particular region, but not actually used all of them in the Validation

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1