Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed empty/unused functions from DBService #2734

Merged

Conversation

Dr15Jones
Copy link
Contributor

To make future maintenance easier and avoid possible thread-safety
issues I removed empty functions and the one unused function
which returned a pointer to the internals of the Service.

To make future maintenance easier and avoid possible thread-safety
issues I removed empty functions and the one unused function
which returned a pointer to the internals of the Service.
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2014

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Removed empty/unused functions from DBService

It involves the following packages:

RecoLuminosity/LumiProducer

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

What happens to this service if multiple threads call DBService::connectReadOnly or DBService::disconnect simultaneously? Similarly, are the coral::ISessionProxy classes thread-safe?

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2014

@anton-a
Copy link

anton-a commented Mar 7, 2014

+1
Does not affect reco

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Mar 8, 2014
…ervice

Multithreading -- Removed empty/unused functions from DBService
@ktf ktf merged commit 6030c0b into cms-sw:CMSSW_7_1_X Mar 8, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
@Dr15Jones Dr15Jones deleted the removedUnusedFunctionsFromDBService branch March 17, 2014 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants