Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecal DQM update #2735

Merged
merged 3 commits into from Mar 8, 2014
Merged

Ecal DQM update #2735

merged 3 commits into from Mar 8, 2014

Conversation

yiiyama
Copy link
Contributor

@yiiyama yiiyama commented Mar 5, 2014

This update is a major restructuring of the ECAL DQM code. Each "task" was previously defined as independent EDAnalyzer and was repeated for EB and EE; now there is only one EDAnalyzer for the DQM source and one for the client, and the individual tasks are called by the analyzer as worker sub-modules. This eliminates the repetition of common procedures (setting up the monitor elements, retrieving the collection from Event, etc.) among the tasks, and makes the development and management of the code simpler.
There is little change in terms of the quantities being monitored, but the appearance of some plots change as empty, unfilled bins were removed. Also, calibration-related histograms were taken out of the standard offline DQM sequence as they also were permanently empty.
A technical documentation is being prepared in https://twiki.cern.ch/twiki/bin/viewauth/CMS/EcalDQMDevelopmentManual

…ready for a long time but were not used. EcalDQMonitorTask will take over all EB/EEXYZTask modules, and EcalDQMonitorClient will take over EB/EEXYZClient.

See twiki EcalDQMDevelopmentManual for details.
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2014

A new Pull Request was created by @yiiyama (Yutaro Iiyama) for CMSSW_7_1_X.

Ecal DQM update

It involves the following packages:

DQM/EcalBarrelMonitorClient
DQM/EcalBarrelMonitorDbModule
DQM/EcalBarrelMonitorTasks
DQM/EcalCommon
DQM/EcalEndcapMonitorTasks
DQMOffline/Configuration
DQMOffline/Ecal

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2014

-1
When I ran the RelVals I found an error in the following worklfows:
8.0 step3

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step3_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2735/373/summary.html

@yiiyama
Copy link
Contributor Author

yiiyama commented Mar 6, 2014

The cosmic MC sequence failed because DQMOffline.Configuration.DQMOfflineCosmics_Harvesting_cff was referencing EB and EE certification tasks, which do not exist any more (merged to ECAL certification). Fixed by commit be8d2ac

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2014

Pull request #2735 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2014

@deguio
Copy link
Contributor

deguio commented Mar 7, 2014

+1
this has been presented and discussed at the DQM meeting [1]. it is a major change and was tested already since 2012 in the online.

[1]
https://indico.cern.ch/event/294170/contribution/3/material/slides/0.pdf

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Mar 8, 2014
@ktf ktf merged commit 3423295 into cms-sw:CMSSW_7_1_X Mar 8, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
@yiiyama yiiyama deleted the ecal-dqm-new-framework branch April 17, 2014 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants