New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecal DQM update #2735
Ecal DQM update #2735
Conversation
…ready for a long time but were not used. EcalDQMonitorTask will take over all EB/EEXYZTask modules, and EcalDQMonitorClient will take over EB/EEXYZClient. See twiki EcalDQMDevelopmentManual for details.
A new Pull Request was created by @yiiyama (Yutaro Iiyama) for CMSSW_7_1_X. Ecal DQM update It involves the following packages: DQM/EcalBarrelMonitorClient @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks. |
-1 runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step3_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log you can see the results of the tests here: |
The cosmic MC sequence failed because DQMOffline.Configuration.DQMOfflineCosmics_Harvesting_cff was referencing EB and EE certification tasks, which do not exist any more (merged to ECAL certification). Fixed by commit be8d2ac |
+1 [1] |
This update is a major restructuring of the ECAL DQM code. Each "task" was previously defined as independent EDAnalyzer and was repeated for EB and EE; now there is only one EDAnalyzer for the DQM source and one for the client, and the individual tasks are called by the analyzer as worker sub-modules. This eliminates the repetition of common procedures (setting up the monitor elements, retrieving the collection from Event, etc.) among the tasks, and makes the development and management of the code simpler.
There is little change in terms of the quantities being monitored, but the appearance of some plots change as empty, unfilled bins were removed. Also, calibration-related histograms were taken out of the standard offline DQM sequence as they also were permanently empty.
A technical documentation is being prepared in https://twiki.cern.ch/twiki/bin/viewauth/CMS/EcalDQMDevelopmentManual