Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversion from EDAnalyzer to DQMEDAnalyzer #2737

Merged

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Mar 5, 2014

as pointing it out from the DQM core team
in order to go towards the multithread, the source DQM code has to be migrated from the EDAnalyzer to the DQMEDAnalyzer [https://indico.cern.ch/event/226671/material/slides/0?contribId=0]

this PR is needed for the tracking DQM code

@mtosi
Copy link
Contributor Author

mtosi commented Mar 5, 2014

@deguio @threus

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2014

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_1_X.

conversion from EDAnalyzer to DQMEDAnalyzer

It involves the following packages:

DQM/TrackingMonitor

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2014

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
@deguio
Copy link
Contributor

deguio commented Mar 11, 2014

ciao @mtosi
what you did is not complete. the booking of the histograms has to be done through the ibooker.
have a look at:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/ThreadedDQM#How_to_migrate_the_code_The_DQME

the booking methods of the DQMStore will be made private once the migration finishes.
could you update this pull request?
thanks,
F.

@mtosi
Copy link
Contributor Author

mtosi commented Mar 12, 2014

ciao,
I've just updated the code and re-pushed this branch
hope it is fine, now
and sorry again for the missing part in my previous request

@deguio

@cmsbuild
Copy link
Contributor

Pull request #2737 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Mar 14, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Mar 14, 2014
DQM/TrackingMonitor -- conversion from EDAnalyzer to DQMEDAnalyzer
@nclopezo nclopezo merged commit 1a40144 into cms-sw:CMSSW_7_1_X Mar 14, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Update L1Trigger-L1TGlobal to tag V00-00-07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants