Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package dependency problems in Alignment #27384

Merged
merged 2 commits into from Jun 28, 2019
Merged

Fix package dependency problems in Alignment #27384

merged 2 commits into from Jun 28, 2019

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • Fixed circular dependency between CommonAlignment and TrackerAlignment/MuonAlignment
  • Fixed missing links needed for UBSAN to work

PR validation:

Code compiles and links in the CMSSW_11_0_UBSAN_X_2019-06-25-2300 IB.

@Dr15Jones
Fix circular dependency between Alignment packages
70108ad 
Previously CommonAlignment was dependent on TrackerAlignment and
MuonAlignment with both the latter dependent on the former.
Changing to using a templated function breaks that dependency while
still keeping the implementation associated with AlignableObjectId.
@Dr15Jones
Fixed missing links in Alignment packages
e80fb33 
Links are needed to make UBSAN work.
@cmsbuild cmsbuild added this to the CMSSW_11_0_X milestone Jun 27, 2019
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@Dr15Jones Dr15Jones mentioned this pull request Jun 27, 2019
Closed
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27384/10662

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

Alignment/CommonAlignment
Alignment/MillePedeAlignmentAlgorithm
Alignment/SurveyAnalysis
Alignment/TrackerAlignment

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@pakhotin, @adewit, @tocheng, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 27, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1231/console Started: 2019/06/27 17:58

@cmsbuild
Copy link
Contributor

+1
Tested at: e80fb33
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fd842/1231/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fd842/1231/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3255670
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3255334
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@pohsun
Copy link

pohsun commented Jun 28, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 99a39ae into cms-sw:master Jun 28, 2019
@Dr15Jones Dr15Jones deleted the fixAlignmentCircularDep branch July 9, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved code-checks-approved comparison-available fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_0_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @pohsun @fabiocos