Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular dependences inside SIM packages #27452

Merged
merged 2 commits into from Jul 7, 2019

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Jul 6, 2019

PR description:

This is the fix of circular dependences identified in #27451
The new model of special CMS tracking cut is now moved from GFlash to PhysicsLists, corresponding modifications are added. GFlash sub-package itself is problematic and should be reviewed further.

PR validation:

private simulation run

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2019

The code-checks are being triggered in jenkins.

@civanch
Copy link
Contributor Author

civanch commented Jul 6, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27452/10767

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1349/console Started: 2019/07/06 17:53

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2019

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/Application
SimG4Core/GFlash
SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-911604/1349/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3160399
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3160063
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@civanch
Copy link
Contributor Author

civanch commented Jul 7, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jul 7, 2019

+1

@cmsbuild cmsbuild merged commit 2eefe00 into cms-sw:master Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants