cms.optional and obsolete now return None from call to value()

[Dr15Jones]

PR description:

WMAgent code was failing when dealing with the new optional and obsolete parameter types. The code was always calling value() which was not available on parameters which were not set.

PR validation:

• FWCore/ParameterSet unit tests pass
• A 'hacked' up version of Configuration/PyReleaseValidation/python/MatrixInjector.py which was able to show the failure reported in Issue with new optional parameter in 11_0_0_pre3 #27453 runs to completion with this change.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27454/10772

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/ParameterSet

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1354/console Started: 2019/07/07 18:26

[cmsbuild]

+1
Tested at: 07fff50
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-959baa/1354/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-959baa/1354/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3160399
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3160063
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@prebello @zhenhu do you have the possibility to perform an injection test using this PR on top of CMSSW_11_0_0_PRE3?

[ahmad3213]

@fabiocos , i have performed an injection test and problem is gone now. Thank you

[fabiocos]

+1