Fix SLHCUpgradeSimulations/Geometry unit test after geometry scenarios cleaning #27499

fabiocos · 2019-07-11T13:24:46Z

PR description:

The integration of #27449 has removed several obsolete upgrade geometry scenarios, among them D21, and this causes the unit test in SLHCUpgradeSimulations/Geometry to fail. This PR updates the test to the supported scenario D41.

PR validation:

15:14 cmsdev25 2698> scram b runtests
Reading cached build data
>> Local Products Rules ..... started
>> Local Products Rules ..... done
>> Entering Package SLHCUpgradeSimulations/Geometry
>> Creating project symlinks
>> Leaving Package SLHCUpgradeSimulations/Geometry
>> Package SLHCUpgradeSimulations/Geometry built
Creating test log file logs/slc7_amd64_gcc700/testing.log
Package SLHCUpgradeSimulations/Geometry: Running test testPhase2PixelNtuple
 
===== Test "testPhase2PixelNtuple" ====
argument 0: testPhase2PixelNtuple
argument 1: /bin/bash
argument 2: SLHCUpgradeSimulations/Geometry/test
argument 3: phase2_digi_reco_pixelntuple.sh
shell is: /bin/bash
Current directory is: /build/fabiocos/110X/code-fix/CMSSW_11_0_X_2019-07-11-1100
topdir is: /build/fabiocos/110X/code-fix/CMSSW_11_0_X_2019-07-11-1100
testdir is: /build/fabiocos/110X/code-fix/CMSSW_11_0_X_2019-07-11-1100/src/SLHCUpgradeSimulations/Geometry/test
tmpdir is: /build/fabiocos/110X/code-fix/CMSSW_11_0_X_2019-07-11-1100/tmp/slc7_amd64_gcc700
testbin is: /build/fabiocos/110X/code-fix/CMSSW_11_0_X_2019-07-11-1100/test/slc7_amd64_gcc700
Running script: /build/fabiocos/110X/code-fix/CMSSW_11_0_X_2019-07-11-1100/src/SLHCUpgradeSimulations/Geometry/test/phase2_digi_reco_pixelntuple.sh
11-Jul-2019 15:14:50 CEST  Initiating request to open file root://eoscms.cern.ch//eos/cms/store/relval/CMSSW_10_6_0_patch2/RelValSingleMuPt10/GEN-SIM/106X_upgrade2023_realistic_v3_2023D41noPU-v1/10000/7377ED92-245C-CC4D-9F05-25ABB5522A08.root
%MSG-w XrdAdaptorInternal:  file_open 11-Jul-2019 15:14:51 CEST pre-events
Failed to open file at URL root://eoscms.cern.ch:1094//eos/cms/store/relval/CMSSW_10_6_0_patch2/RelValSingleMuPt10/GEN-SIM/106X_upgrade2023_realistic_v3_2023D41noPU-v1/10000/7377ED92-245C-CC4D-9F05-25ABB5522A08.root.
%MSG
%MSG-w XrdAdaptorInternal:  file_open 11-Jul-2019 15:14:51 CEST pre-events
Failed to open file at URL root://eoscms.cern.ch:1094//eos/cms/store/relval/CMSSW_10_6_0_patch2/RelValSingleMuPt10/GEN-SIM/106X_upgrade2023_realistic_v3_2023D41noPU-v1/10000/7377ED92-245C-CC4D-9F05-25ABB5522A08.root?tried=.
%MSG
11-Jul-2019 15:14:51 CEST  Fallback request to file root://xrootd-cms.infn.it//store/relval/CMSSW_10_6_0_patch2/RelValSingleMuPt10/GEN-SIM/106X_upgrade2023_realistic_v3_2023D41noPU-v1/10000/7377ED92-245C-CC4D-9F05-25ABB5522A08.root
[2019-07-11 15:14:56.800621 +0200][Warning][XRootDTransport   ] [[2620:6a:0:8420::a5]:17287 #0.0] Logged in, accepting empty login response.
%MSG-w XrdAdaptor:  file_open 11-Jul-2019 15:14:56 CEST pre-events
Data is served from [2620 instead of original site infn.it
%MSG
11-Jul-2019 15:14:59 CEST  Successfully opened file root://xrootd-cms.infn.it//store/relval/CMSSW_10_6_0_patch2/RelValSingleMuPt10/GEN-SIM/106X_upgrade2023_realistic_v3_2023D41noPU-v1/10000/7377ED92-245C-CC4D-9F05-25ABB5522A08.root
Begin processing the 1st record. Run 1, Event 2, LumiSection 1 on stream 0 at 11-Jul-2019 15:16:42.773 CEST
Begin processing the 2nd record. Run 1, Event 8, LumiSection 1 on stream 0 at 11-Jul-2019 15:16:55.987 CEST
Begin processing the 3rd record. Run 1, Event 7, LumiSection 1 on stream 0 at 11-Jul-2019 15:17:03.432 CEST
Begin processing the 4th record. Run 1, Event 10, LumiSection 1 on stream 0 at 11-Jul-2019 15:17:10.379 CEST
Begin processing the 5th record. Run 1, Event 9, LumiSection 1 on stream 0 at 11-Jul-2019 15:17:17.487 CEST
Begin processing the 6th record. Run 1, Event 4, LumiSection 1 on stream 0 at 11-Jul-2019 15:17:24.765 CEST
Begin processing the 7th record. Run 1, Event 11, LumiSection 1 on stream 0 at 11-Jul-2019 15:17:32.851 CEST
Begin processing the 8th record. Run 1, Event 5, LumiSection 1 on stream 0 at 11-Jul-2019 15:17:40.009 CEST
Begin processing the 9th record. Run 1, Event 12, LumiSection 1 on stream 0 at 11-Jul-2019 15:17:47.353 CEST
Begin processing the 10th record. Run 1, Event 16, LumiSection 1 on stream 0 at 11-Jul-2019 15:17:54.330 CEST
11-Jul-2019 15:18:02 CEST  Closed file root://xrootd-cms.infn.it//store/relval/CMSSW_10_6_0_patch2/RelValSingleMuPt10/GEN-SIM/106X_upgrade2023_realistic_v3_2023D41noPU-v1/10000/7377ED92-245C-CC4D-9F05-25ABB5522A08.root

=============================================

MessageLogger Summary

 type     category        sev    module        subroutine        count    total
 ---- -------------------- -- ---------------- ----------------  -----    -----
    1 XrdAdaptor           -w file_open                              1        1
    2 XrdAdaptorInternal   -w file_open                              2        2
    3 fileAction           -s file_close                             1        1
    4 fileAction           -s file_open                              3        3

 type    category    Examples: run/evt        run/evt          run/evt
 ---- -------------------- ---------------- ---------------- ----------------
    1 XrdAdaptor           pre-events                        
    2 XrdAdaptorInternal   pre-events       pre-events       
    3 fileAction           PostGlobalEndRun                  
    4 fileAction           pre-events       pre-events       pre-events

Severity    # Occurrences   Total Occurrences
--------    -------------   -----------------
Warning                 3                   3
System                  4                   4

dropped waiting message count 0
status = 0

---> test testPhase2PixelNtuple succeeded
 
^^^^ End Test testPhase2PixelNtuple ^^^^
>> Tests for package SLHCUpgradeSimulations/Geometry ran.

…s cleaning

cmsbuild · 2019-07-11T13:25:13Z

The code-checks are being triggered in jenkins.

fabiocos · 2019-07-11T13:26:09Z

@emiglior FYI

cmsbuild · 2019-07-11T13:31:20Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27499/10834

This PR adds an extra 12KB to repository

cmsbuild · 2019-07-11T13:31:45Z

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

SLHCUpgradeSimulations/Geometry

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

fabiocos · 2019-07-11T13:32:36Z

please test

cmsbuild · 2019-07-11T13:33:04Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1426/console Started: 2019/07/11 15:33

kpedro88 · 2019-07-11T14:59:16Z

@fabiocos thanks; this will have to be fixed again with the renaming in #27488, so either I can rebase or just include this change in that PR

fabiocos · 2019-07-11T15:05:45Z

@kpedro88 I think you may just rebase on this when it is integrated, this looks simple in itself and mightr enter already tonight

kpedro88 · 2019-07-11T15:06:55Z

That works for me.

cmsbuild · 2019-07-11T15:14:46Z

+1
Tested at: 1f47b0d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5901d8/1426/summary.html

cmsbuild · 2019-07-11T15:14:50Z

Comparison job queued.

cmsbuild · 2019-07-11T17:54:58Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5901d8/1426/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-5901d8/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-5901d8/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D41+RecoFullGlobal_2023D41+HARVESTFullGlobal_2023D41
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-5901d8/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D44+RecoFullGlobal_2023D44+HARVESTFullGlobal_2023D44

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 1 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3081858
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3081535
DQMHistoTests: Total skipped: 322
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

kpedro88 · 2019-07-11T18:25:39Z

+upgrade

fabiocos · 2019-07-11T19:55:03Z

+1

fabiocos · 2019-07-11T19:55:36Z

@cvuosalo @ianna this just fixes a unit test by updating the geometry scenario

fabiocos · 2019-07-11T19:55:46Z

merge

cvuosalo · 2019-07-11T20:27:42Z

+1

cmsbuild · 2019-07-11T20:28:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Fix SLHCUpgradeSimulations/Geometry unit test after geometry scenario…

1f47b0d

…s cleaning

cmsbuild added this to the CMSSW_11_0_X milestone Jul 11, 2019

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Jul 11, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 11, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 11, 2019

cmsbuild added tests-approved and removed tests-started labels Jul 11, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jul 11, 2019

kpedro88 mentioned this pull request Jul 11, 2019

Be consistent when replacing a module or Sequence in a Process #27480

Merged

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 11, 2019

cmsbuild added orp-approved and removed orp-pending labels Jul 11, 2019

cmsbuild merged commit 84e97bb into cms-sw:master Jul 11, 2019

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Jul 11, 2019

fabiocos deleted the fc-fixPost27449 branch August 7, 2019 13:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix SLHCUpgradeSimulations/Geometry unit test after geometry scenarios cleaning #27499

Fix SLHCUpgradeSimulations/Geometry unit test after geometry scenarios cleaning #27499

fabiocos commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

fabiocos commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

fabiocos commented Jul 11, 2019

cmsbuild commented Jul 11, 2019 •

edited

kpedro88 commented Jul 11, 2019

fabiocos commented Jul 11, 2019

kpedro88 commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

kpedro88 commented Jul 11, 2019

fabiocos commented Jul 11, 2019

fabiocos commented Jul 11, 2019

fabiocos commented Jul 11, 2019

cvuosalo commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

Fix SLHCUpgradeSimulations/Geometry unit test after geometry scenarios cleaning #27499

Fix SLHCUpgradeSimulations/Geometry unit test after geometry scenarios cleaning #27499

Conversation

fabiocos commented Jul 11, 2019

PR description:

PR validation:

cmsbuild commented Jul 11, 2019

fabiocos commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

fabiocos commented Jul 11, 2019

cmsbuild commented Jul 11, 2019 • edited

kpedro88 commented Jul 11, 2019

fabiocos commented Jul 11, 2019

kpedro88 commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

kpedro88 commented Jul 11, 2019

fabiocos commented Jul 11, 2019

fabiocos commented Jul 11, 2019

fabiocos commented Jul 11, 2019

cvuosalo commented Jul 11, 2019

cmsbuild commented Jul 11, 2019

cmsbuild commented Jul 11, 2019 •

edited