Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore new ROOT error message about TH1 nbins <=0 #2756

Merged
merged 1 commit into from Mar 7, 2014

Conversation

Dr15Jones
Copy link
Contributor

When we switched to ROOT 5.34.17 a new warning message appeared
when TH1 is passed nbins <= 0. Since ROOT already sets the value
to nbins=1 we can ignore this warning.

When we switched to ROOT 5.34.17 a new warning message appeared
when TH1 is passed nbins <= 0. Since ROOT already sets the value
to nbins=1 we can ignore this warning.

Conflicts:
	FWCore/Services/src/InitRootHandlers.cc
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2014

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Ignore new ROOT error message about TH1 nbins <=0

It involves the following packages:

FWCore/Services

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Mar 7, 2014
ROOT 5.34.17 -- Ignore new ROOT error message about TH1 nbins <=0
@ktf ktf merged commit ad8e3a7 into cms-sw:CMSSW_7_1_X Mar 7, 2014
@Dr15Jones
Copy link
Contributor Author

@ktf Giulio, even with this fix, the 'Verbose' error still remains.

@Dr15Jones Dr15Jones deleted the ignoreNBinsZero_7_1_X branch March 7, 2014 12:39
@ktf
Copy link
Contributor

ktf commented Mar 8, 2014

Ok. Let me check..

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants