Validation/RecoEgamma/plugins recOfflineVertices histogram parameters modification V2 #27561
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27561/10955
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
… code-format patch.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27561/10956
|
|
A new Pull Request was created by @archiron (Chiron) for master. It involves the following packages: Validation/RecoEgamma @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@archiron trivial question: you say that the new histogram definition is adapted to Run3; is it also still functional to validate older setups as well? |
|
silly question, you have increased the possible PU range without moving the lower value, the answer is obviously yes |
|
+1 |
|
Yes. I made also tests with 11_0_0_pre2 and 10_6_0_pre4, as with 10_6_1 without any failure.Arnaud Envoyé depuis mon appareil mobile Samsung.
-------- Message d'origine --------De : Fabio Cossutti <notifications@github.com> Date : 20/07/2019 20:33 (GMT+01:00) À : cms-sw/cmssw <cmssw@noreply.github.com> Cc : Chiron <arnaud.chiron@cern.ch>, Mention <mention@noreply.github.com> Objet : Re: [cms-sw/cmssw] Validation/RecoEgamma/plugins recOfflineVertices histogram parameters modification V2 (#27561) @archiron trivial question: you say that the new histogram definition is adapted to Run3; is it also still functional to validate older setups as well?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "#27561?email_source=notifications\u0026email_token=ABKT7HZVVCBGM53QJYHHQN3QANK5NA5CNFSM4IFDTQA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2NTVJI#issuecomment-513489573",
"url": "#27561?email_source=notifications\u0026email_token=ABKT7HZVVCBGM53QJYHHQN3QANK5NA5CNFSM4IFDTQA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2NTVJI#issuecomment-513489573",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
|
Hello, |
PR description:
in the electron validation (Validation/RecoEgamma/plugins) we made a small modification in the recOfflineVertices histogram (nb of bins and nb of vertices shown) to adapt the nvertices plot range to the Run 3 PU conditions.
we can show the new conformation on linked picture.
PR validation:
compilation is OK, basics tests (scram b runtests or local tests) are OK to.
runTheMatrix.py -l limited -i all --ibeos tests are fine.
if this PR is a backport please specify the original PR:
Before submitting your pull requests, make sure you followed this checklist:
@beaudett