DD4hep:Simulation - DDDWorld Defines Regions and Sets G4 Production Cuts

[ianna]

PR description:

• DD4hep specific constructor for DDG4ProductionCuts
• During its initialization filter geometry on a key word region and fill in a std::vector<std::pair<G4LogicalVolume*, const cms::DDSpecPar*>>
• Use this to create or retrieve a G4Region and assign to it G4ProductionCuts (if they are not already set!). Beware, the cuts defined only once per region. There is no check if they should be overwritten from an extra definition in the xml files.

@civanch - FYI, as discussed during Sim meeting.

PR validation:

cmsRun SimG4Core/DD4hepGeometry/test/python/testZMM_13TeV_TuneCUETP8M1_cfi_GEN_SIM.py

The output is written to simG4test.log

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[ianna]

@civanch - please, let me know if I should open a separate PR for the changes (included here) in the DetectorDescription/DDCMS package. IMHO, they would be useful elsewhere and it would be nice to have them in the IBs asap. Thanks.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27588/11005

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS
SimG4Core/Geometry

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1596/console Started: 2019/07/23 17:28

[cmsbuild]

+1
Tested at: 03a36fe
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-678841/1596/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-678841/1596/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2628546
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2628228
• DQMHistoTests: Total skipped: 317
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[ianna]

+1

[ianna]

@civanch - please, let me know when will you be able to review this PR. Thanks.

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1