[PPS][106X] Diamond DQM patch for 2017

[forthommel]

PR description:

This PR allows rechits with negative OOT index to be discarded in the population of the per-BX activity and pixel tomography monitoring plots for the PPS diamond detector. This allows to fix a std::out_of_range exception raised in e.g. 2017C relvals workflows (see e.g. here), as the time acquisition window was significantly larger (thus increasing the multiplicity of OOT hits).

PR validation:

Same as #27586, successfully tested on the "faulty" workflow on a 10_6_1 release:

$ cmsDriver.py step3 --conditions 106X_dataRun2_v15 \
  -s RAW2DIGI,L1Reco,RECO,SKIM:ZElectron,EI,PAT,ALCA:EcalCalZElectron+EcalUncalZElectron+HcalCalIterativePhiSym+HcalCalIsoTrkFilter,DQM:@standardDQM+@ExtraHLT+@miniAODDQM 
  --runUnscheduled --process reRECO --data --era Run2_2017 \
  --eventcontent RECO,MINIAOD,DQM --hltProcess reHLT --scenario pp \
  --datatier RECO,MINIAOD,DQMIO \
  --customise Configuration/DataProcessing/RecoTLR.customisePostEra_Run2_2017 \
  --filein=/store/relval/CMSSW_10_6_1/DoubleEG/FEVTDEBUGHLT/103X_dataRun2_HLT_relval_v8_stdDQM_RelVal_2017C-v1/20000/9894C3EA-791C-4E47-B4F4-537828FFEF62.root

if this PR is a backport please specify the original PR: #27586

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

A new Pull Request was created by @forthommel (Laurent Forthomme) for CMSSW_10_6_X.

It involves the following packages:

DQM/CTPPS

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@jan-kaspar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from [PPS][106X] Diamond DQM patch for 2017 #27591

[forthommel]

backport of #27591

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1612/console Started: 2019/07/24 16:27

[cmsbuild]

+1
Tested at: 7fb01a6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11a2fe/1612/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11a2fe/1612/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3208248
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3207913
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[forthommel]

Dare I ask what is the current status of this bug fix integration?

[fabiocos]

+1