Define and use cms units #27637

ianna · 2019-07-30T08:08:03Z

PR description:

The CMS convention is that centimeter = 1 and GeV = 1
Use the cms units in the Ecal algorithms

PR validation:

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2019-07-30T08:08:29Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-07-30T08:46:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27637/11137

This PR adds an extra 44KB to repository

cmsbuild · 2019-07-30T08:46:55Z

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DataFormats/Math
Geometry/EcalCommonData

@perrotta, @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @rovere, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

ianna · 2019-07-30T10:25:00Z

please test

cmsbuild · 2019-07-30T10:25:28Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1700/console Started: 2019/07/30 12:25

cmsbuild · 2019-07-30T11:49:56Z

+1
Tested at: 06482d4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec59d8/1700/summary.html

cmsbuild · 2019-07-30T11:49:59Z

Comparison job queued.

cmsbuild · 2019-07-30T13:45:22Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec59d8/1700/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 2628564
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2628245
DQMHistoTests: Total skipped: 317
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

DataFormats/Math/interface/CMSUnits.h

ianna · 2019-07-31T05:30:29Z

+1

ianna · 2019-07-31T06:00:15Z

urgent

in order to fix overlaps where units mismatch is a probable cause. See #27646

slava77 · 2019-08-01T21:10:39Z

---> test ExpressionEvaluatorUnitTest had ERRORS

this does not look related to this PR.
It looks like the same error messages are showing up in the IB builds as well
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc700/CMSSW_11_0_X_2019-08-01-1100/unitTestLogs/CommonTools/Utils#/
however there it doesn't lead to test ExpressionEvaluatorUnitTest had ERRORS

ianna · 2019-08-01T21:11:24Z

+1

@kpedro88 - FYI, failing unit test has nothing to do with the PR:

===== Test "ExpressionEvaluatorUnitTest" ====
10 5
0 1
An exception of category 'ExpressionEvaluator' occurred.
Exception Message:
Bla/Blo/src/precompile.h file not found neither in /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-07-31-2300 nor in /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_11_0_X_2019-07-31-2300 nor in /cvmfs/cms-ib.cern.ch/nweek-02587/slc7_amd64_gcc700/cms/cmssw/CMSSW_11_0_X_2019-07-30-2300 

An exception of category 'ExpressionEvaluator' occurred.
Exception Message:
compilation/linking failed
c++ -H -Wall -shared -Winvalid-pch -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=70401 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DCMSSW_GIT_HASH='"CMSSW_11_0_X_2019-07-31-2300"' -DPROJECT_NAME='"CMSSW"' -DPROJECT_VERSION='"CMSSW_11_0_X_2019-07-31-2300"'              -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++1z -ftree-vectorize -Wstrict-overflow -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -fPIC -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-07-31-2300/include/slc7_amd64_gcc700/ -o /tmp/VI_b06a6265d2e54f839eadbc0b971b5ad6.so /tmp/VI_b06a6265d2e54f839eadbc0b971b5ad6.cc 2>&1
! /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-07-31-2300/include/slc7_amd64_gcc700/CommonTools/Utils/src/precompile.h.gch
 /tmp/VI_b06a6265d2e54f839eadbc0b971b5ad6.cc
/tmp/VI_b06a6265d2e54f839eadbc0b971b5ad6.cc:3:6: error: 'bool VI_b06a6265d2e54f839eadbc0b971b5ad6::operator()(int, int)' marked 'override', but does not override
 bool operator()(int i, int j) override { return i<10&& j<5; }
      ^~~~~~~~
/tmp/VI_b06a6265d2e54f839eadbc0b971b5ad6.cc: In function 'reco::genericExpression<bool, int, int>* factoryVI_b06a6265d2e54f839eadbc0b971b5ad6()':
/tmp/VI_b06a6265d2e54f839eadbc0b971b5ad6.cc:6:44: error: cannot declare variable 'local' to be of abstract type 'VI_b06a6265d2e54f839eadbc0b971b5ad6'
 static VI_b06a6265d2e54f839eadbc0b971b5ad6 local;
                                            ^~~~~
/tmp/VI_b06a6265d2e54f839eadbc0b971b5ad6.cc:2:8: note:   because the following virtual functions are pure within 'VI_b06a6265d2e54f839eadbc0b971b5ad6':
 struct VI_b06a6265d2e54f839eadbc0b971b5ad6 final : public reco::genericExpression<bool, int, int>{
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from src/CommonTools/Utils/src/precompile.h:2:0:
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-07-31-2300/src/CommonTools/Utils/interface/ExpressionEvaluatorTemplates.h:14:17: note: 	Ret reco::genericExpression<Ret, Args>::operator()(Args ...) const [with Ret = bool; Args = {int, int}]
     virtual Ret operator()(Args...) const = 0;
                 ^~~~~~~~
dlerror /tmp/VI_b06a6265d2e54f839eadbc0b971b5ad6.so: cannot open shared object file: No such file or directory 

0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,33,32,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,98,97,99,100,101,102,103,104,105,106,107,108,109,110,111,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128,129,130,131,132,133,134,135,136,137,138,139,140,141,142,143,144,145146,,147,149,148,150,151,152,153,154,155,156,157,158,159,160,161,162,163,164,165,166,167,168,169,170,171,172,173,174,175,176,177,178,179,180,181,182,183,184,185,186,187,188,189,190,191,192,193,194,195,196,197,198,199,200,201,202,203,204,205,206,207,208,209,210,211,212,213,214,215,216,217,218,219,220,221,222,223,224,225,226,227,228,229,230,231,232,233,234,235,236,237,238,239,240,241,242,243,244,245,246,247,248,249,250,251,252,253,254,255,256,257,258,259,260,261,262,263,264,265,266,267,268,269,270,271,272,273,274,275,276,277,278,279,280,281,282,283,284,285,286,287,288,289,290,291,292,294,293,295,296,297,298,299,300,301,302,303,304,305,306,307,308,309,310,311,312,313,314,315,316,317,318,319,320,321,322,323,324,325,326,327,328,329,330,331,332,333,335,334,336,337,338,339,340,341,342,343,344,345,346,347,348,349,350,351,352,353,354,355,356,357,358,359,360,361,362,363,364,365,366,367,368,369,370,371,372,373,374,375,376,378,377,379,380,381,382,383,384,385,386,387,388,389,391,390,392,393,394,395,396,397,398,399,400,401,402,403,404,405,406,407,408,409,410,411,412,413,414,415,416,417,418,419,420,421,422,423,424,425,426,427,428,429,430,431,432,433,434,435,436,437,438,439,440,441,442,443,444,445,446,447,448,449,450,451,452,453,454,455,456,457,458,459,460,461,462,463,464,465,466,467,468,469,470,471,472,473,474,475,476,477,478,479,480,481,482,483,484,485,486,487,490,488,489,491,492,493,494,495,496,497,498,499,500,501,502,503,504,505,506,507,508,509,510,511,512,513,514,515,516,517,518,519,520,521,522,523,524,525,526,527,528,529,530,531,532,533,534,535,536,537,538,540,539,541,542,543,544,545,546,547,548,549,550,551,552,554,555,553,556,557,558,559,560,561,562,563,564,565,566,567,568,569,570,571,572,573,574,576,575,577,579,578,580,581,582,583,584,585,586,587,588,589,590,591,592,593,594,595,596,598,597,599,600,601,602,603,604,605,606,607,608,609,610,611,612,613,614,615,616,617,618,619,620,621,622,623,624,625,626,627,628,629,630,631,632,633,634,635,636,637,638,639,640,641,642,643,644,645,646,647,648,649,650,651,652,653,654,655,656,657,658,659,660,661,662,663,664,665,666,667,668,669,670,671,672,673,674,675,676,678,677,679,680,681,682,683,684,685,686,687,688,689,690,691,692,693,694,695,696,697,698,699,700,701,702,703,704,705,706,707,708,709,710,711,712,713,714,715,716,717,718,719,720,721,722,723,724,725,726,727,728,729,730,731,732,733,734,735,736,737,738,739,740,741,742,743,744,745,747,746,748,749,750,751,752,753,754,755,756,757,758,759,760,761,762,763,764,765,766,767,768,769,770,771,772,773,774,775,777,776,778,779,780,781,782,783,784,785,786,787,788,789,790,791,792,793,794,795,796,797,798,799,800,801,802,803,804,805,806,807,808,809,810,811,812,813,814,815,816,817,818,819,820,821,822,823,824,825,826,827,828,829,830,831,832,833,834,835,836,837,838,839,840,841,842,843,844,845,846,847,848,849,850,851,852,853,854,855,856,857,858,859,860,861,862,863,864,865,866,867,868,869,870,871,872,873,874,875,876,877,878,879,880,881,882,883,884,886,885,887,888,889,890,891,892,893,894,895,896,897,898,899,900,901,902,903,904,905,906,907,908,909,910,911,912,913,914,915,916,917,918,919,920,921,922,923,924,925,926,927,928,929,930,931,932,933,934,935,936,937,938,939,940,941,942,943,944,945,946,947,948,949,950,951,952,953,954,955,956,957,958,959,960,961,962,963,964,965,966,967,968,969,970,971,972,973,974,975,976,977,978,979,980,981,982,983,984,985,986,987,988,989,990,991,992,993,994,995,996,997,998,999,1000,1001,1002,1003,1004,1005,1006,1007,1008,1009,1010,1011,1012,1013,1014,1015,1016,1017,1018,1019,1020,1021,1022,1023,1024,1025,1026,1027,1028,1029,1030,1031,1032,1033,1034,1035,1036,1037,1038,1039,1040,1041,1042,1043,1044,1045,1046,1047,1048,1049,1050,1051,1052,1053,1054,1055,1056,1057,1058,1059,1060,1061,1062,1063,1064,1065,1066,1067,1068,1069,1070,1071,1072,1073,1074,1075,1076,1077,1078,1079,1080,1081,1082,1083,1084,1085,1086,1087,1088,1089,1090,1091,1093,1092,1094,1095,1096,1097,1098,1099,1100,1101,1102,1103,1104,1105,1106,1107,1108,1109,1110,1111,1112,1113,1114,1115,1116,1117,1118,1119,1120,1121,1122,1123,1124,1125,1126,1127,1128,1129,1130,1131,1132,1133,1134,1135,1136,1137,1138,1139,1140,1141,1142,1143,1144,1145,1146,1147,1148,1149,1150,1151,1152,1153,1154,1155,1156,1157,1158,1159,1160,1161,1162,1163,1164,1165,1167,1166,1168,1169,1170,1171,1172,1173,1174,1175,1176,1177,1178,1179,1180,1181,1182,1183,1184,1185,1186,1187,1188,1189,1190,1191,1192,1193,1194,1195,1196,1197,1198,1199,1200,1201,1202,1203,1204,1205,1206,1207,1208,1209,1210,1211,1212,1213,1214,1215,1216,1217,1218,1219,1220,1221,1222,1223,1224,1225,1226,1227,1228,1229,1230,1231,1232,1233,1234,1235,1236,1237,1238,1239,1240,1241,1242,1243,1244,1245,1246,1247,1248,1249,1250,1251,1252,1253,1254,1255,1256,1257,1258,1259,1260,1261,1262,1263,1264,1265,1266,1267,1268,1269,1270,1271,1272,1273,1274,1275,1276,1277,1278,1279,1280,1281,1282,1283,1284,1285,1286,1287,1288,1289,1290,1291,1292,1293,1294,1295,1296,1297,1298,1299,1300,1301,1302,1303,1304,1305,1306,1307,1308,1309,1310,1311,1312,1313,1314,1315,1316,1317,1318,13191320,,1321,1322,1323,1324,1325,1326,1327,1328,1329,1330,1331,1332,1333,1334,1335,1336,1337,1338,1339,1340,1341,1342,1343,1344,1345,1346,1347,1348,1349,1350,1351,1352,1353,1354,1355,1356,1357,1358,1359,1360,1361,1362,1363,1364,1365,1366,1367,
---> test ExpressionEvaluatorUnitTest had ERRORS
 
^^^^ End Test ExpressionEvaluatorUnitTest ^^^^

ianna · 2019-08-01T21:14:27Z

@kpedro88 - FYI, this PR does not need a simulation signature. It was accidentally added by referring to a #26227

kpedro88 · 2019-08-01T21:15:28Z

@slava77 to me this unit test issue looks like the same problem we saw in #27506

kpedro88 · 2019-08-01T21:17:30Z

@ianna package DataFormats/GeometryVector is in the simulation category

ianna · 2019-08-01T21:29:13Z

@mrodozov - FYI, it's the same unit test failing here

ianna · 2019-08-02T05:49:34Z

@civanch - please review

mrodozov · 2019-08-02T09:49:29Z

@ianna I'm checking it.

ianna · 2019-08-02T15:19:23Z

@smuzaffar and @mrodozov - could you, please, drop the red flag for the tests since it has nothing to do with current PR? Thanks.

smuzaffar · 2019-08-02T15:25:14Z

unit test failing here has nothing to do with this PR. I have updated the cmsbot test comment to mark the test passed

civanch · 2019-08-02T19:26:31Z

+1

cmsbuild · 2019-08-02T19:27:00Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

kpedro88 · 2019-08-02T21:33:28Z

+1

Define and use cms units

06482d4

cmsbuild added this to the CMSSW_11_0_X milestone Jul 30, 2019

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jul 30, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 30, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 30, 2019

cmsbuild added tests-approved and removed tests-started labels Jul 30, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jul 30, 2019

cvuosalo reviewed Jul 30, 2019

View reviewed changes

DataFormats/Math/interface/CMSUnits.h Show resolved Hide resolved

cmsbuild added geometry-approved and removed geometry-pending labels Jul 31, 2019

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Aug 1, 2019

cmsbuild added geometry-approved and removed geometry-pending labels Aug 1, 2019

vargasa added a commit to vargasa/cmssw that referenced this pull request Aug 2, 2019

Use CMSUnits instead: See cms-sw#27637

be18d57

vargasa mentioned this pull request Aug 2, 2019

DD4hep: Tracker usage of CMSUnits #27679

Merged

cmsbuild added tests-approved and removed tests-rejected labels Aug 2, 2019

vargasa added a commit to vargasa/cmssw that referenced this pull request Aug 2, 2019

Use CMSUnits instead: See cms-sw#27637

2ed7341

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Aug 2, 2019

cmsbuild added orp-approved and removed orp-pending labels Aug 2, 2019

cmsbuild merged commit 473cbe6 into cms-sw:master Aug 2, 2019

vargasa added a commit to vargasa/cmssw that referenced this pull request Aug 3, 2019

Use CMSUnits instead: See cms-sw#27637

650ea39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Define and use cms units #27637

Define and use cms units #27637

ianna commented Jul 30, 2019

cmsbuild commented Jul 30, 2019

cmsbuild commented Jul 30, 2019

cmsbuild commented Jul 30, 2019

ianna commented Jul 30, 2019

cmsbuild commented Jul 30, 2019 •

edited

cmsbuild commented Jul 30, 2019

cmsbuild commented Jul 30, 2019

cmsbuild commented Jul 30, 2019

ianna commented Jul 31, 2019

ianna commented Jul 31, 2019

slava77 commented Aug 1, 2019

ianna commented Aug 1, 2019

ianna commented Aug 1, 2019

kpedro88 commented Aug 1, 2019

kpedro88 commented Aug 1, 2019

ianna commented Aug 1, 2019

ianna commented Aug 2, 2019

mrodozov commented Aug 2, 2019

ianna commented Aug 2, 2019

smuzaffar commented Aug 2, 2019

civanch commented Aug 2, 2019

cmsbuild commented Aug 2, 2019

kpedro88 commented Aug 2, 2019

Define and use cms units #27637

Define and use cms units #27637

Conversation

ianna commented Jul 30, 2019

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Jul 30, 2019

cmsbuild commented Jul 30, 2019

cmsbuild commented Jul 30, 2019

ianna commented Jul 30, 2019

cmsbuild commented Jul 30, 2019 • edited

cmsbuild commented Jul 30, 2019

cmsbuild commented Jul 30, 2019

cmsbuild commented Jul 30, 2019

ianna commented Jul 31, 2019

ianna commented Jul 31, 2019

slava77 commented Aug 1, 2019

ianna commented Aug 1, 2019

ianna commented Aug 1, 2019

kpedro88 commented Aug 1, 2019

kpedro88 commented Aug 1, 2019

ianna commented Aug 1, 2019

ianna commented Aug 2, 2019

mrodozov commented Aug 2, 2019

ianna commented Aug 2, 2019

smuzaffar commented Aug 2, 2019

civanch commented Aug 2, 2019

cmsbuild commented Aug 2, 2019

kpedro88 commented Aug 2, 2019

cmsbuild commented Jul 30, 2019 •

edited