Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the TTI scenario #2765

Merged
merged 4 commits into from Mar 7, 2014
Merged

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Mar 7, 2014

--> make it run with Be5D10D
--> removing unnecessary steps in runthematrix (reco- harvesting)
--> calling explicitely localreco to be run (as it's supposed to be in MC prod)
--> rework a bit the customize for making it more standard
tested with runTheMatrix.py --what upgrade -l 12800

according to the summary it seems that maybe there is a merging pb with a recent change in combine_customs
related to hcal phase2 and ecal time...

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2014

A new Pull Request was created by @boudoul (boudoul) for CMSSW_6_2_X_SLHC.

Rework the TTI scenario

It involves the following packages:

Configuration/PyReleaseValidation
Geometry/TrackerGeometryBuilder
SLHCUpgradeSimulations/Configuration

@civanch, @Dr15Jones, @vlimant, @ianna, @mdhildreth, @cmsbuild, @franzoni, @nclopezo, @Degano, @ktf, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

Tests 10000, 10200, 11200, 11400, 11600, 11800 and 12000 pass as before.
Tests 12200, 12400, 12600, 13200 and 13400 fail in step 2 as before.

12800 (TTI) now runs all the way - 2 steps is all that's required.
10400 (BE5D) now fails in step 3 where it previously passed all steps.
13000 (Extended2023Muon) now fails in step 2 where it previously passed all steps.

Errors for 12200, 12400, 12600, 13200 and 13400 are all the known ones documented in https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideUpgradeGeom#Status_of_run_TheMatrix_workflow.

Error in configuration of step 3 for 10400:

----- Begin Fatal Exception 07-Mar-2014 15:04:57 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=SiPixelClusterProducer label='siPixelClusters'
Exception Message:
Duplicate Process The process name RECO was previously used on these products.
Please modify the configuration file to use a distinct process name.
----- End Fatal Exception -------------------------------------------------

This looks a little odd - not sure how that could come up. I'll try the test again.

Error in step 2 for 13000:

----- Begin Fatal Exception 07-Mar-2014 15:13:23 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
A std::exception was thrown.
vector::_M_range_check
----- End Fatal Exception -------------------------------------------------

@@ -1224,7 +1224,7 @@ def genvalid(fragment,d,suffix='all',fi=''):
}
if upgradeCustoms[k]!=None : upgradeStepDict['DigiFull'][k]['--customise']=upgradeCustoms[k]

upgradeStepDict['DigiTrkTrigFull'][k] = {'-s':'DIGI:pdigi_valid,L1,L1TrackTrigger,DIGI2RAW',
upgradeStepDict['DigiTrkTrigFull'][k] = {'-s':'DIGI:pdigi_valid,L1,L1TrackTrigger,DIGI2RAW,RECO:pixeltrackerlocalreco',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is breaking the BE5D tests. Because partial reco has already been done in step 2, when full reco is done in step3 it complains that "RECO was previously used on these products". Does BE5D need to use DigiTrkTrigFull? I don't know what/whom this scenario is for.

Possible fixes:

  1. Change BE5D to use DigiFull.
  2. If BE5D needs track triggering run, change it so that it only has GEN-SIM and DIGI steps.
  3. Revert the change on this line, and have a step 3 for track trigger e.g. RecoTrkTrig which just has RECO:pixeltrackerlocalreco

@boudoul
Copy link
Contributor Author

boudoul commented Mar 7, 2014

ah good catch!
so BE5D does not need anymore DigiTrkTrigFull, only 2023TTI

@mark-grimes
Copy link

Do you mind taking care of that? Updating your branch should automatically update the pull request.

@boudoul
Copy link
Contributor Author

boudoul commented Mar 7, 2014

No pb, I will do just after my dpg meeting, ~1/2h

@boudoul
Copy link
Contributor Author

boudoul commented Mar 7, 2014

should be better now...

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2014

Pull request #2765 was updated. @civanch, @Dr15Jones, @vlimant, @ianna, @mdhildreth, @cmsbuild, @franzoni, @nclopezo, @Degano, @ktf, @davidlange6 can you please check and sign again.

@boudoul
Copy link
Contributor Author

boudoul commented Mar 7, 2014

ahah I still notice that one hcalphase2 is not synchronized in my combinedcustoms, make a quick test and will updtae that too...

@boudoul
Copy link
Contributor Author

boudoul commented Mar 7, 2014

voila, should be ok now, and I also fixed the GT for BE5D and BE5DPixel10D , the 2019 was used instead of PLS3...

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2014

Pull request #2765 was updated. @civanch, @Dr15Jones, @vlimant, @ianna, @mdhildreth, @cmsbuild, @franzoni, @nclopezo, @Degano, @ktf, @davidlange6 can you please check and sign again.

@mark-grimes
Copy link

merge

Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800, 12000, 12800 and 13000 pass all steps.
Tests 12200, 12400, 12600, 13200 and 13400 fail in step 2 with known errors.
12800 now passes both steps.

cmsbuild added a commit that referenced this pull request Mar 7, 2014
@cmsbuild cmsbuild merged commit cc02f32 into cms-sw:CMSSW_6_2_X_SLHC Mar 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants