New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the TTI scenario #2765
Rework the TTI scenario #2765
Conversation
A new Pull Request was created by @boudoul (boudoul) for CMSSW_6_2_X_SLHC. Rework the TTI scenario It involves the following packages: Configuration/PyReleaseValidation @civanch, @Dr15Jones, @vlimant, @ianna, @mdhildreth, @cmsbuild, @franzoni, @nclopezo, @Degano, @ktf, @davidlange6 can you please review it and eventually sign? Thanks. |
Tests 10000, 10200, 11200, 11400, 11600, 11800 and 12000 pass as before. 12800 (TTI) now runs all the way - 2 steps is all that's required. Errors for 12200, 12400, 12600, 13200 and 13400 are all the known ones documented in https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideUpgradeGeom#Status_of_run_TheMatrix_workflow. Error in configuration of step 3 for 10400:
This looks a little odd - not sure how that could come up. I'll try the test again. Error in step 2 for 13000:
|
@@ -1224,7 +1224,7 @@ def genvalid(fragment,d,suffix='all',fi=''): | |||
} | |||
if upgradeCustoms[k]!=None : upgradeStepDict['DigiFull'][k]['--customise']=upgradeCustoms[k] | |||
|
|||
upgradeStepDict['DigiTrkTrigFull'][k] = {'-s':'DIGI:pdigi_valid,L1,L1TrackTrigger,DIGI2RAW', | |||
upgradeStepDict['DigiTrkTrigFull'][k] = {'-s':'DIGI:pdigi_valid,L1,L1TrackTrigger,DIGI2RAW,RECO:pixeltrackerlocalreco', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is breaking the BE5D tests. Because partial reco has already been done in step 2, when full reco is done in step3 it complains that "RECO was previously used on these products". Does BE5D need to use DigiTrkTrigFull? I don't know what/whom this scenario is for.
Possible fixes:
- Change BE5D to use DigiFull.
- If BE5D needs track triggering run, change it so that it only has GEN-SIM and DIGI steps.
- Revert the change on this line, and have a step 3 for track trigger e.g. RecoTrkTrig which just has RECO:pixeltrackerlocalreco
ah good catch! |
Do you mind taking care of that? Updating your branch should automatically update the pull request. |
No pb, I will do just after my dpg meeting, ~1/2h |
should be better now... |
Pull request #2765 was updated. @civanch, @Dr15Jones, @vlimant, @ianna, @mdhildreth, @cmsbuild, @franzoni, @nclopezo, @Degano, @ktf, @davidlange6 can you please check and sign again. |
ahah I still notice that one hcalphase2 is not synchronized in my combinedcustoms, make a quick test and will updtae that too... |
voila, should be ok now, and I also fixed the GT for BE5D and BE5DPixel10D , the 2019 was used instead of PLS3... |
Pull request #2765 was updated. @civanch, @Dr15Jones, @vlimant, @ianna, @mdhildreth, @cmsbuild, @franzoni, @nclopezo, @Degano, @ktf, @davidlange6 can you please check and sign again. |
merge Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800, 12000, 12800 and 13000 pass all steps. |
--> make it run with Be5D10D
--> removing unnecessary steps in runthematrix (reco- harvesting)
--> calling explicitely localreco to be run (as it's supposed to be in MC prod)
--> rework a bit the customize for making it more standard
tested with runTheMatrix.py --what upgrade -l 12800
according to the summary it seems that maybe there is a merging pb with a recent change in combine_customs
related to hcal phase2 and ecal time...