New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Payload Inspector for SiPixel conditions #27658
Introduce Payload Inspector for SiPixel conditions #27658
Conversation
code-checks |
The code-checks are being triggered in jenkins. |
@mmusich this PR is not supposed to affect production workflows, but it provides standalone tools to inspect payloads, am I correct? |
that's right. It needs to be in release in order for the ConDB Browser to be able to access to the plugin libraries. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27658/11345
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR aims to introduce the first few classes for the inspection of SiPixel conditions, namely the
SiPixelLorentzAngle
and theSiPixelQuality
. More classes for other conditions types will be added at a later time.PR validation:
The code has been privately tested using the scripts provided in the
CondCore/SiPixelPlugins/test
directory.In the particular case of the
SiPixelQuality
Bad ROC maps a dedicated validation has been done, by cross-checking the output of the payload inspector, with the content of theMonitorElement
s used for monitoring the PCL output in the Phase-1 pixel DQM ( example )Example of output image to be displayed in Conditions Browser from one of the classes introduced here:
if this PR is a backport please specify the original PR:
This PR is not a backport.
cc:
@tvami @tsusa