Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Payload Inspector for SiPixel conditions #27658

Merged
merged 25 commits into from Aug 12, 2019

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 31, 2019

PR description:

This PR aims to introduce the first few classes for the inspection of SiPixel conditions, namely the SiPixelLorentzAngle and the SiPixelQuality. More classes for other conditions types will be added at a later time.

PR validation:

The code has been privately tested using the scripts provided in the CondCore/SiPixelPlugins/test directory.
In the particular case of the SiPixelQuality Bad ROC maps a dedicated validation has been done, by cross-checking the output of the payload inspector, with the content of the MonitorElements used for monitoring the PCL output in the Phase-1 pixel DQM ( example )
Example of output image to be displayed in Conditions Browser from one of the classes introduced here:

CheckROCsBPix

if this PR is a backport please specify the original PR:

This PR is not a backport.
cc:
@tvami @tsusa

@fabiocos
Copy link
Contributor

fabiocos commented Aug 8, 2019

code-checks

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

The code-checks are being triggered in jenkins.

@fabiocos
Copy link
Contributor

fabiocos commented Aug 8, 2019

@mmusich this PR is not supposed to affect production workflows, but it provides standalone tools to inspect payloads, am I correct?

@mmusich
Copy link
Contributor Author

mmusich commented Aug 8, 2019

@fabiocos

PR is not supposed to affect production workflows, but it provides standalone tools to inspect payloads, am I correct?

that's right. It needs to be in release in order for the ConDB Browser to be able to access to the plugin libraries.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27658/11345

  • This PR adds an extra 84KB to repository

@fabiocos
Copy link
Contributor

fabiocos commented Aug 8, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1893/console Started: 2019/08/08 10:25

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca4f27/1893/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 2715989
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2715659
  • DQMHistoTests: Total skipped: 329
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Aug 12, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit eaed829 into cms-sw:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants