HGCal - Minimum Cluster size for Pattern Recognition

[felicepantaleo]

PR description:

This PR is introducing a new filter on the minimum layer clusters size that a hgcalLayerCluster requires in order to be passed to the next step of the Pattern Recognition in TICL. This is useful to make PR more robust against single cell inefficiency and to remove duplicate tracksters.

PR validation:

This PR was tested with 20490.0_SingleGammaPt25Eta1p7_2p7 checking that the number of hgcalLayerClusters fed to the pattern recognition is halved, and that the number of duplicate tracksters is decreased.
Another PR will be made in order to make the Pattern Recognition by CA more robust as well.

@rovere @cseez @amartelli fyi

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27666/11234

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoHGCal/TICL/python/ticl_iterations.py modified in PR(s): HGCAL TICL seeded iteration  #27439, Add energy regression and particle identification to RecoHGCal/TICL. #27634

[cmsbuild]

A new Pull Request was created by @felicepantaleo (Felice Pantaleo) for master.

It involves the following packages:

RecoHGCal/TICL

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@clelange this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

please test workflow 20493.52

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1782/console Started: 2019/08/01 20:44

[cmsbuild]

+1
Tested at: b3cbe30
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70f33f/1782/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70f33f/1782/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2492470
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2492152
• DQMHistoTests: Total skipped: 317
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 132 log files, 14 edm output root files, 32 DQM output files

[kpedro88]

+upgrade

[slava77]

this is already a part of filteredLayerClustersProducer PSet. Is this redundant change really necessary here?

[slava77]

+1

for #27666 b3cbe30

• code changes are in line with the PR description (although it could be more clear that this is replacing an old filter, not just "introducing a new filter")
• jenkins tests pass and comparisons with the baseline show no differences because the TICL workflow is not used in comparisons in the tests

#27666 (review) is minor enough and applies only to an experimental config/customization.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1