Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix short matrix for 2021 #27678

Merged
merged 1 commit into from Aug 3, 2019
Merged

fix short matrix for 2021 #27678

merged 1 commit into from Aug 3, 2019

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Aug 2, 2019

PR description:

One-line fix for #27433 (based on comment in #27644 (comment))

@kpedro88
Copy link
Contributor Author

kpedro88 commented Aug 2, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27678/11265

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1807/console Started: 2019/08/02 15:59

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

Comparison job queued.

@kpedro88
Copy link
Contributor Author

kpedro88 commented Aug 2, 2019

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-615667/1807/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-615667/11634.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2492470
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2492152
  • DQMHistoTests: Total skipped: 317
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 132 log files, 14 edm output root files, 32 DQM output files

@zhenhu
Copy link
Contributor

zhenhu commented Aug 3, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@@ -74,7 +74,7 @@ def runSelected(opt):
10024.0, #2017 ttbar
10224.0, #2017 ttbar PU
10824.0, #2018 ttbar
11624.0, #2021 ttbar
11634.0, #2021 ttbar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make the runner throw if the workflow is not available?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slava77 this is a good suggestion, I would manage it independently on this PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given some failures in 2023,2024 in some other tests, should we add at least one to the limited set?

@fabiocos
Copy link
Contributor

fabiocos commented Aug 3, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants