Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD4hep: Tracker usage of CMSUnits #27679

Merged
merged 4 commits into from Aug 5, 2019
Merged

DD4hep: Tracker usage of CMSUnits #27679

merged 4 commits into from Aug 5, 2019

Conversation

vargasa
Copy link
Contributor

@vargasa vargasa commented Aug 2, 2019

PR description:

It should be tested on top of PR:#27637

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

The code-checks are being triggered in jenkins.

@ianna
Copy link
Contributor

ianna commented Aug 2, 2019

hold

@cmsbuild cmsbuild added the hold label Aug 2, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27679/11266

  • This PR adds an extra 60KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27679/11267

  • This PR adds an extra 72KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27679/11271

  • This PR adds an extra 72KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@ianna
Copy link
Contributor

ianna commented Aug 3, 2019

unhold

@cmsbuild cmsbuild removed the hold label Aug 3, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27679/11284

  • This PR adds an extra 72KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2019

A new Pull Request was created by @vargasa (Andrés Vargas) for master.

It involves the following packages:

DetectorDescription/DDCMS
Geometry/HcalAlgo
Geometry/MuonCommonData
Geometry/TrackerCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@makortel, @VinInn, @ptcox, @ebrondol, @ghugo83, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ianna
Copy link
Contributor

ianna commented Aug 3, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1824/console Started: 2019/08/03 18:07

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88db77/1824/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2492470
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2492150
  • DQMHistoTests: Total skipped: 317
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 132 log files, 14 edm output root files, 32 DQM output files

@ianna
Copy link
Contributor

ianna commented Aug 3, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Aug 5, 2019

+1

@cmsbuild cmsbuild merged commit 203bc98 into cms-sw:master Aug 5, 2019
@vargasa vargasa deleted the CMSUnits branch October 9, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants