throw a meaninful error if LFN isn't found in FileCatalog #27695
Conversation
|
The code-checks are being triggered in jenkins. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27695/11305
|
|
A new Pull Request was created by @dan131riley (Dan Riley) for master. It involves the following packages: IOPool/Streamer @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
| <use name="FWCore/ServiceRegistry"/> | ||
| <use name="FWCore/Services"/> | ||
| <use name="FWCore/ParameterSetReader"/> | ||
| <flags TEST_RUNNER_ARGS="all"/> |
There was a problem hiding this comment.
is all a special value known by scram?
There was a problem hiding this comment.
I see that it is an option known by ReadStreamerFile
There was a problem hiding this comment.
Right, it's just an arg to the test program, scram doesn't know anything about the value. Alternatively we could make all the default and get rid of the arg, which might be safer--previously the arg was set to a nonsense string and as a result the tests weren't even being run.
|
Comparison job queued. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
PR description:
When the StreamerFileReader tries to process an LFN that doesn't have a valid PFN translation, it currently tries to open the file "", leading to difficult to diagnose errors at the Tier0, see this thread:
https://hypernews.cern.ch/HyperNews/CMS/get/edmFramework/3876/1/1/1/2/1/1/2/1.html
This PR throws a LogicalFileNameNotFound error if the PFN is empty. Some code changes needed to be made to the error message could include the LFN that resulted in an empty PFN.
PR validation:
Code was tested on the Tier0 repack job configuration from the HN thread, confirming that a working config still worked, and a config with an invalid LFN resulted in a meaningful error message.
In addition the ReadStreamerFile test was repaired (it wasn't running the tests and always returned success), and a new test case added to verify that an invalid LFN results in the correct exception.