New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Geant4 sequential #27706
Fixed Geant4 sequential #27706
Conversation
The code-checks are being triggered in jenkins. |
The code-checks are being triggered in jenkins. |
The code-checks are being triggered in jenkins. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27706/11326
|
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages: SimG4Core/Application @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27706/11359
|
Pull request #27706 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 @civanch thanks for the update |
Comparison is ready Comparison Summary:
|
PR description:
During recent modifications for SIM (triggered by DD4Hep migration) Geant4 sequential run using OscarProducer was slightly broken. This PR restore this functionality. Note, that this mode does not used, instead we are using OscarMTProducer everywhere.
Additionally, few basic parameters of these producers moved from untracked to normal.
No change in regression is expected.
PR validation:
private
if this PR is a backport please specify the original PR:
Before submitting your pull requests, make sure you followed this checklist: