New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore updated PPS association cuts for 2017 #27709
Conversation
This reverts commit 41eca26.
A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_10_6_X. It involves the following packages: RecoCTPPS/ProtonReconstruction @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Thank you @fabiocos ! |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@srimanob as agreed I integrate this PR in view of next 10_6_X build for 2017 UL |
+1 |
PR description:
This reverts commit 41eca26 , restoring the optimised 2017 association cuts for PPS (present in master, reverted to the default in 10_6_X for backward compatibility).
As the 2017 production should likely be restarted for unrelated reasons this PR offers the possibility to get the best scenario also for 2017.
PR validation:
See #27440