Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore updated PPS association cuts for 2017 #27709

Merged
merged 1 commit into from Aug 8, 2019

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Aug 7, 2019

PR description:

This reverts commit 41eca26 , restoring the optimised 2017 association cuts for PPS (present in master, reverted to the default in 10_6_X for backward compatibility).

As the 2017 production should likely be restarted for unrelated reasons this PR offers the possibility to get the best scenario also for 2017.

PR validation:

See #27440

@fabiocos fabiocos changed the title Restore update PPS association cuts for 2017 Restore updated PPS association cuts for 2017 Aug 7, 2019
@cmsbuild cmsbuild added this to the CMSSW_10_6_X milestone Aug 7, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_10_6_X.

It involves the following packages:

RecoCTPPS/ProtonReconstruction

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@forthommel, @jan-kaspar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Aug 7, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1870/console Started: 2019/08/07 16:19

@jan-kaspar
Copy link
Contributor

Thank you @fabiocos !

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6755c/1870/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211049
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3210713
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Aug 8, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor Author

fabiocos commented Aug 8, 2019

@srimanob as agreed I integrate this PR in view of next 10_6_X build for 2017 UL

@fabiocos
Copy link
Contributor Author

fabiocos commented Aug 8, 2019

+1

@cmsbuild cmsbuild merged commit 781d8a3 into cms-sw:CMSSW_10_6_X Aug 8, 2019
@fabiocos fabiocos deleted the fc-restorePPS2017 branch August 9, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants