Move 2015/2016 Data ReReco ZeroBias RelVals to use @rerecoZeroBias DQM sequence #27727

mmusich · 2019-08-08T13:22:14Z

PR description:

This PR completes the effort started in PR #27415 to move the Data ReReco ZeroBias RelVal workflows to use the @rerecoZeroBias DQM sequence.
As a reminder this is done in order to test the sequence that is actually run at Tier-0 during physics certification and spot beforehand possible issues affecting production.
In #27415 it was not directly possible to activate the changes in the 2015 / 2016 workflows (already prepared), because they would have failed with the error reported in #27415 (comment):

----- Begin Fatal Exception 27-Jun-2019 11:22:17 CEST-----------------------
An exception of category 'StdException' occurred while
[0] Processing global end LuminosityBlock run: 251251 luminosityBlock: 139
[1] Calling method for module SiPixelCertification/'sipixelCertification'
Exception Message:
A std::exception was thrown.
DQM object not found: Pixel/EventInfo/reportSummary
----- End Fatal Exception -------------------------------------------------

It turns out that this error is due to the fact that with the current definition of the rerecoZeroBias sequence, the sequence dqmHarvestingExtraHLT which runs the DQMOffline_Certification

cmssw/Configuration/StandardSequences/python/Harvesting_cff.py

Line 16 in e43377b

    
           dqmHarvestingFakeHLT = cms.Path(DQMOffline_SecondStep_FakeHLT*DQMOffline_Certification)

which is defined as

cmssw/DQMOffline/Configuration/python/DQMOffline_Certification_cff.py

Line 9 in 50022b6

    
           DQMOffline_Certification = cms.Sequence(daq_dqmoffline*dcs_dqmoffline*crt_dqmoffline)

which in turn contains sipixelCertification

cmssw/DQMOffline/Configuration/python/DQMOffline_CRT_cff.py

Line 17 in 02d4198

sipixelCertification *

is put into the cms.schedule execution before the actual execution of the Pixel harvesting step, resulting into looking for an histogram which is not yet created.

N.B.: Resolving the @rerecoZeroBias harvesting sequence into its actual sub-sequences solves the issue, but I am not sure it's the most elegant way of doing it. Suggestion are welcome.

PR validation:

Run the standard battery of tests for the workflows which have been changed:

 runTheMatrix.py -l 134.710,134.812,134.912,136.732,136.745,136.756,136.767,136.778 -t 4 -j 8 --ibeos

which passed without issues.

if this PR is a backport please specify the original PR:

This is not a backport, though a backport might be needed for the actual 2016 Ultra-Legacy reprocessing.

cc:
@jandrea @arossi83

cmsbuild · 2019-08-08T13:22:45Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-08-08T13:28:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27727/11350

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_standard.py modified in PR(s): Add bx skim and corresponding RelVal #26476

cmsbuild · 2019-08-08T13:29:17Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Configuration/PyReleaseValidation
DQMOffline/Configuration

@cmsbuild, @andrius-k, @kmaeshima, @zhenhu, @schneiml, @prebello, @kpedro88, @pgunnell, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @threus, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

prebello · 2019-08-08T14:04:34Z

please test workflow 134.710,134.812,134.912,136.732,136.745,136.756,136.767,136.778

cmsbuild · 2019-08-08T14:05:02Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1910/console Started: 2019/08/08 16:05

fioriNTU · 2019-08-08T14:49:56Z

@prebello it is possible also a fix for HCAL RelVals in this PR, @mmusich is running the tests

prebello · 2019-08-08T15:25:44Z

ok no problem thank you @fioriNTU
should I abort the test then?

mmusich · 2019-08-08T15:29:04Z

@prebello no need for the moment. I will update the PR in a few minutes, once my local tests complete, and the tests will need to be relaunched in any case.

cmsbuild · 2019-08-08T15:46:09Z

+1
Tested at: 2ba2983
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c773b/1910/summary.html

cmsbuild · 2019-08-08T15:46:12Z

Comparison job queued.

…l DQM request

…16 workflows too

cmsbuild · 2019-08-12T19:39:33Z

+1
Tested at: c4afc8b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c773b/1976/summary.html

cmsbuild · 2019-08-12T19:39:38Z

Comparison job queued.

cmsbuild · 2019-08-12T22:10:17Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c773b/1976/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-3c773b/134.71_RunZeroBias2015B+RunZeroBias2015B+HLTDR2_50ns+RECODR2_50nsreHLT_ZB_HIPM+HARVESTDR2ZB
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-3c773b/134.812_RunZeroBias2015C+RunZeroBias2015C+HLTDR2_25ns+RECODR2_25nsreHLT_ZB_HIPM+HARVESTDR2ZB
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-3c773b/134.912_RunZeroBias2015D+RunZeroBias2015D+HLTDR2_25ns+RECODR2_25nsreHLT_ZB_HIPM+HARVESTDR2ZB
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-3c773b/136.732_RunZeroBias2016B+RunZeroBias2016B+HLTDR2_2016+RECODR2_2016reHLT_ZB_HIPM+HARVESTDR2ZB
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-3c773b/136.745_RunZeroBias2016C+RunZeroBias2016C+HLTDR2_2016+RECODR2_2016reHLT_ZB_HIPM+HARVESTDR2ZB
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-3c773b/136.756_RunZeroBias2016D+RunZeroBias2016D+HLTDR2_2016+RECODR2_2016reHLT_ZB_HIPM+HARVESTDR2ZB
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-3c773b/136.767_RunZeroBias2016E+RunZeroBias2016E+HLTDR2_2016+RECODR2_2016reHLT_ZB_HIPM+HARVESTDR2ZB
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-3c773b/136.778_RunZeroBias2016H+RunZeroBias2016H+HLTDR2_2016+RECODR2_2016reHLT_ZBPrompt+HARVESTDR2ZB

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2939508
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2939166
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 142 log files, 14 edm output root files, 34 DQM output files

jfernan2 · 2019-08-13T10:56:03Z

Thanks @mmusich
I believe this is ready to go once @mmusich confirms all the needed plots are in the ZeroBias workflows

mmusich · 2019-08-13T11:51:21Z

@jfernan2
I streamed a couple of output 2015 / 2016 relval files into a private development GUI:

ssh -NL 8060:localhost:8060 USER@lxplus796.cern.ch
https://tinyurl.com/yytkzxwl

things look in good order to me, a screenshot as an example:

jfernan2 · 2019-08-13T12:21:30Z

+1
Thanks @mmusich

fabiocos · 2019-08-13T14:24:27Z

@prebello @zhenhu @chayanit could you please check?
@kpedro88 as far as I can see this looks ok to move forward

chayanit · 2019-08-13T14:28:15Z

+1

fabiocos · 2019-08-13T20:09:55Z

+1

fabiocos · 2019-08-13T20:10:14Z

merge

kpedro88 · 2019-08-19T17:32:07Z

+upgrade

cmsbuild · 2019-08-19T17:32:38Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

mmusich added 2 commits August 8, 2019 15:01

resolve sequence in its subcomponents

a964d88

move in 2015 and 2017 @standardDQM to @rerecoZeroBias

2ba2983

cmsbuild added this to the CMSSW_11_0_X milestone Aug 8, 2019

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Aug 8, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 8, 2019

cmsbuild added tests-started and removed tests-pending labels Aug 8, 2019

cmsbuild added tests-approved and removed tests-started labels Aug 8, 2019

mmusich added 2 commits August 8, 2019 19:28

take care also of @rerecoZeroBiasFakeHLT and add @hcal2 as per centra…

0ed00e0

…l DQM request

move to @rerecoZeroBiasFakeHLT instead of @rerecoZeroBias for 2015/20…

9e68768

…16 workflows too

cmsbuild removed the code-checks-approved label Aug 8, 2019

cmsbuild added tests-started and removed tests-pending labels Aug 12, 2019

cmsbuild added tests-approved and removed tests-started labels Aug 12, 2019

cmsbuild added comparison-available and removed comparison-pending labels Aug 12, 2019

cmsbuild mentioned this pull request Aug 13, 2019

apply postEra customization for HI 2018 data #27755

Merged

cmsbuild added dqm-approved and removed dqm-pending labels Aug 13, 2019

cmsbuild added pdmv-approved and removed pdmv-pending labels Aug 13, 2019

cmsbuild added orp-approved and removed orp-pending labels Aug 13, 2019

cmsbuild merged commit 32094e4 into cms-sw:master Aug 13, 2019

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Aug 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move 2015/2016 Data ReReco ZeroBias RelVals to use @rerecoZeroBias DQM sequence #27727

Move 2015/2016 Data ReReco ZeroBias RelVals to use @rerecoZeroBias DQM sequence #27727

mmusich commented Aug 8, 2019

cmsbuild commented Aug 8, 2019

cmsbuild commented Aug 8, 2019

cmsbuild commented Aug 8, 2019

prebello commented Aug 8, 2019

cmsbuild commented Aug 8, 2019 •

edited

fioriNTU commented Aug 8, 2019

prebello commented Aug 8, 2019

mmusich commented Aug 8, 2019 •

edited

cmsbuild commented Aug 8, 2019

cmsbuild commented Aug 8, 2019

cmsbuild commented Aug 12, 2019

cmsbuild commented Aug 12, 2019

cmsbuild commented Aug 12, 2019

jfernan2 commented Aug 13, 2019

mmusich commented Aug 13, 2019

jfernan2 commented Aug 13, 2019

fabiocos commented Aug 13, 2019

chayanit commented Aug 13, 2019

fabiocos commented Aug 13, 2019

fabiocos commented Aug 13, 2019

kpedro88 commented Aug 19, 2019

cmsbuild commented Aug 19, 2019

Navigation Menu

Move 2015/2016 Data ReReco ZeroBias RelVals to use @rerecoZeroBias DQM sequence #27727

Move 2015/2016 Data ReReco ZeroBias RelVals to use @rerecoZeroBias DQM sequence #27727

Conversation

mmusich commented Aug 8, 2019

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Aug 8, 2019

cmsbuild commented Aug 8, 2019

cmsbuild commented Aug 8, 2019

prebello commented Aug 8, 2019

cmsbuild commented Aug 8, 2019 • edited

fioriNTU commented Aug 8, 2019

prebello commented Aug 8, 2019

mmusich commented Aug 8, 2019 • edited

cmsbuild commented Aug 8, 2019

cmsbuild commented Aug 8, 2019

cmsbuild commented Aug 12, 2019

cmsbuild commented Aug 12, 2019

cmsbuild commented Aug 12, 2019

jfernan2 commented Aug 13, 2019

mmusich commented Aug 13, 2019

jfernan2 commented Aug 13, 2019

fabiocos commented Aug 13, 2019

chayanit commented Aug 13, 2019

fabiocos commented Aug 13, 2019

fabiocos commented Aug 13, 2019

kpedro88 commented Aug 19, 2019

cmsbuild commented Aug 19, 2019

cmsbuild commented Aug 8, 2019 •

edited

mmusich commented Aug 8, 2019 •

edited