DD4hep: Tracker overlaps on PixelForwardDiskRings

[vargasa]

PR description:

Addresses overlaps on Tracker PixFwdDisk*Rings

PR validation:

master

master + thisPr

Reference

For validation instructions check: #27689 (comment)

PATH:
/Tracker_2/PixelForwardZminus_1/pixfwdDisks:PixelForwardDiskZminus_1

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27736/11367

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @vargasa (Andrés Vargas) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1940/console Started: 2019/08/09 16:30

[cmsbuild]

+1
Tested at: 66d099a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef8892/1940/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• DD4hep: Numeric vector units parsing  #27725 @vargasa: DD4hep: Numeric vector units parsing
• Bug fix for 2016-2017 HBHE negative energy filter #27733 @christopheralanwest: Bug fix for 2016-2017 HBHE negative energy filter
• Add explicit fallthrough attribute to hash64 #27714 @Dr15Jones: Add explicit fallthrough attribute to hash64
• DD4hep: Update to a new DD4hep version - no need to cleanup #27728 @ianna: DD4hep: Update to a new DD4hep version - no need to cleanup

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef8892/1940/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef8892/1940/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef8892/1940/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2396 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 95
• DQMHistoTests: Total nulls: 6
• DQMHistoTests: Total successes: 2939066
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.098 KiB( 33 files compared)
• DQMHistoSizes: changed ( 136.788 ): 0.098 KiB JetMET/SUSYDQM
• Checked 142 log files, 14 edm output root files, 34 DQM output files

[ianna]

+1

the differences in reco reported here are not related to this PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1949/console Started: 2019/08/10 21:51

[cmsbuild]

+1
Tested at: 66d099a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef8892/1949/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef8892/1949/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939166
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 142 log files, 14 edm output root files, 34 DQM output files

[fabiocos]

+1