New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce DD exposure to help with furter DD4hep migration #27742
Conversation
The code-checks are being triggered in jenkins. |
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27742/11380
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27742/11383
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: CondTools/Geometry @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @ggovi can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
+1 |
Comparison is ready Comparison Summary:
|
+1 |
@ggovi please comment or sign it |
@ggovi I would like to merge this PR, the DB part looks ok to me, please have a look |
@ggovi - please, review |
+1 |
+1 |
merge @kpedro88 please have a look in case |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
@cvuosalo - FYI, let's see if this cleanup can help
PR validation:
if this PR is a backport please specify the original PR:
Before submitting your pull requests, make sure you followed this checklist: