Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce DD exposure to help with furter DD4hep migration #27742

Merged
merged 8 commits into from Aug 16, 2019

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Aug 10, 2019

PR description:

  • Replace DDName with string
  • Remove DDExpandedView
  • Cleanup

@cvuosalo - FYI, let's see if this cleanup can help

PR validation:

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27742/11380

  • This PR adds an extra 68KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@ianna
Copy link
Contributor Author

ianna commented Aug 10, 2019

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27742/11383

  • This PR adds an extra 116KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 10, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1950/console Started: 2019/08/10 22:17

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

CondTools/Geometry
DetectorDescription/Core
Geometry/MTDGeometryBuilder
Geometry/MTDNumberingBuilder
Geometry/TrackerGeometryBuilder
Geometry/TrackerNumberingBuilder
SLHCUpgradeSimulations/Geometry

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @ggovi can you please review it and eventually sign? Thanks.
@makortel, @ebrondol, @VinInn, @mmusich, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@ianna
Copy link
Contributor Author

ianna commented Aug 13, 2019

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8bad1/2001/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939508
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2939166
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 142 log files, 14 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

@ggovi please comment or sign it

@fabiocos
Copy link
Contributor

@ggovi I would like to merge this PR, the DB part looks ok to me, please have a look

@ianna
Copy link
Contributor Author

ianna commented Aug 16, 2019

@ggovi - please, review

@ggovi
Copy link
Contributor

ggovi commented Aug 16, 2019

+1

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@kpedro88 please have a look in case

@cmsbuild cmsbuild merged commit 6312135 into cms-sw:master Aug 16, 2019
@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants