HCAL DQMOffline: adding rechits spectra with enabled cleaning

[abdoulline]

PR description:

Additional 4 HB/HE/HO/HF rechits energy spectra with noise cleaning applied.
To explicitly assess the effect of cleaning at the level of HCAL RecHits, as in CaloTowers plots (with the cleaning applied) it may not be well visible...

PR validation:

runTheMatris is OK in 11_0_0_pre5

if this PR is a backport please specify the original PR:

no backport is needed

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27748/11391

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27748/11391/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27748/11391/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27748/11392

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27748/11392/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27748/11392/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27748/11394

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @abdoulline (Salavat Abdullin) for master.

It involves the following packages:

DQMOffline/Hcal

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fioriNTU]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1965/console Started: 2019/08/12 13:15

[cmsbuild]

+1
Tested at: 565eeb3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6e854/1965/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6e854/1965/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939166
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1768.004 KiB( 33 files compared)
• DQMHistoSizes: changed ( 12434.0,... ): 63.152 KiB HcalRecHitsD/HcalRecHitTask
• DQMHistoSizes: changed ( 12434.0,... ): 63.109 KiB HLT/HCAL
• Checked 142 log files, 14 edm output root files, 34 DQM output files

[jfernan2]

@abdoulline it seems that in addition to the 4 plots you mention in the PR description (appearing on HcalRecHitsD/HcalRecHitTask folder), the PR is also adding the same 4 extra plots on HLT/HCAL /RecHits folder (EMPTY in 10XYZ wfs) only in MC workflows 10042.0, 10224.0, 10824.0, 11634.0, 12434.0
Can you plase check?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_0_X_2019-08-12-1100+a6e854/33048/dqm-histo-comparison-summary.html

[abdoulline]

If I remember it right, Mia Tosi (HLT) has "borrowed" this analyser a couple of years ago for some HLT needs:
https://github.com/cms-sw/cmssw/blob/master/DQMOffline/Hcal/python/HLTHcalRecHitParam_cfi.py

[jfernan2]

@mtosi do we need those HLT/HCAL histograms?

[abdoulline]

@jfernan2
this small PR stays idle 4 weeks...

[jfernan2]

@abdoulline yes we are waiting for @mtosi to confirm
Mia, any hint about this?
Thanks

[mtosi]

ciao
I’m no longer in STEAM :(
in général, whatever is used for the offline monitor of the local reconstruction, it should be used in the online as well (if the same reconstruction is used)

said that, i would suggest to cross check with the current HCAL at HLT expert/contact/convener if these plots are used and useful

in my opinion it would be the case, but ...

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1