DD4hep: Tracker overlaps TIB

[vargasa]

PR description:

master overlaps:

master + thisPr Overlaps:

PR validation:

cmsRun test/python/testTracker2021Geometry.py >Tracker2021.log
cmsShow -c overlaps.fwc --sim-geom-file cmsDD4HepGeom.root --tgeo-name=CMS


Path:
/Tracker_2/TIDB_2

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27761/11423

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @vargasa (Andrés Vargas) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1998/console Started: 2019/08/13 12:34

[ianna]

@vargasa - very nice!

[cmsbuild]

-1

Tested at: 503abc1

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Update RivetInterface for Rivet 3.x #27610 @intrepid42: Update RivetInterface for Rivet 3.x

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a4066/1998/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a4066/1998/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a4066/1998/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

• Build:

I found compilation error when building:

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/DQMRivetClient.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/ParticleLevelProducer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/RivetAnalyzer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/HTXSRivetProducer.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/HTXSRivetProducer.cc:19:0:
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/src/HiggsTemplateCrossSections.cc:65:25: error: 'ConstGenParticlePtr' does not name a type; did you mean 'GenParticlePtr'?
     bool hasChild(const ConstGenParticlePtr &ptcl, int pdgID) {
                         ^~~~~~~~~~~~~~~~~~~
                         GenParticlePtr
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/src/HiggsTemplateCrossSections.cc:73:26: error: 'ConstGenParticlePtr' does not name a type; did you mean 'GenParticlePtr'?
     bool hasParent(const ConstGenParticlePtr &ptcl, int pdgID) {


• Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/ParticleLevelProducer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/GenParticles2HepMCConverter.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/DQMRivetClient.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/HTXSRivetProducer.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/plugins/HTXSRivetProducer.cc:19:
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/src/HiggsTemplateCrossSections.cc:65:25: error: unknown type name 'ConstGenParticlePtr'
    bool hasChild(const ConstGenParticlePtr &ptcl, int pdgID) {
                        ^
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-08-12-2300/src/GeneratorInterface/RivetInterface/src/HiggsTemplateCrossSections.cc:73:26: error: unknown type name 'ConstGenParticlePtr'
    bool hasParent(const ConstGenParticlePtr &ptcl, int pdgID) {
                         ^


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Update RivetInterface for Rivet 3.x #27610 @intrepid42: Update RivetInterface for Rivet 3.x

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a4066/1998/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a4066/1998/git-merge-result

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[ianna]

@fabiocos - the reported errors are due to the other PR merged in the IBs

[mseidel42]

Hi, I guess it included #27610 but not cms-sw/cmsdist#5107

Should be fixed with next IB?

[mseidel42]

This may work: please test with cms-sw/cmsdist#5107

(or wait for next IB tomorrow)

[fabiocos]

please just wait for next IB to build, unfortunately sooner or later we need to break for a few hours in order to integrate this external

[vargasa]

Hello @fabiocos. Just checking, is there anything to be done here?

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2052/console Started: 2019/08/16 10:29

[cmsbuild]

+1
Tested at: 503abc1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a4066/2052/summary.html

[cmsbuild]

Comparison job queued.

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a4066/2052/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939166
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 142 log files, 14 edm output root files, 34 DQM output files

[fabiocos]

@vargasa @ianna in this PR you are essentially promoting a LogDebug to LogInfo (LogVerbatim is just an unformatted LogInfo), is this really needed/desired ?

[vargasa]

Hi @fabiocos. Yes, at this phase of development it is needed.

[fabiocos]

+1