Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use puppi jets for phase2 scenario for PF validation #27764

Merged
merged 1 commit into from Aug 14, 2019

Conversation

hatakeyamak
Copy link
Contributor

@hatakeyamak hatakeyamak commented Aug 13, 2019

PR description:

Monitor puppi jets instead of ak4 chs jets for phase2 scenarios

PR validation:

Compiles. Tested with phase2 scenarios.

if this PR is a backport please specify the original PR:

Not backport.

@juska @bendavid

@hatakeyamak hatakeyamak changed the title use puppi jets for phase2 scenario Use puppi jets for phase2 scenario for PF validation Aug 13, 2019
@cmsbuild cmsbuild added this to the CMSSW_11_0_X milestone Aug 13, 2019
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27764/11432

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hatakeyamak (Kenichi Hatakeyama) for master.

It involves the following packages:

Validation/RecoParticleFlow

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 13, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2005/console Started: 2019/08/13 19:50

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d82d7e/2005/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939508
  • DQMHistoTests: Total failures: 203
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2938964
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 142 log files, 14 edm output root files, 34 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

DQM changes are only in phase2 workflows for PFlow JetResponse, as expected

@hatakeyamak
Copy link
Contributor Author

hatakeyamak commented Aug 14, 2019

Yes, looks good to me too.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1797746 into cms-sw:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants