New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-sim43 Expand passive hits to contain PDG Id of track and store this in CaloSteppingAction #27776
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27776/11458
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27776/11459
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: SimDataFormats/CaloHit @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27776/11460
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27776/11461
|
Pull request #27776 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@bsunanda in my understanding this data format is not part of the regular production, and it is used for dedicated studies, am I correct? |
+1 |
PR description:
Expand the contents of PassiveHit class to contain PDG ID of the track causing the hit and this information is now saved in CaloSteppingAction class
PR validation:
Tested privately using the python script SimG4CMS/Calo/test/python/calostep_cfg.py
if this PR is a backport please specify the original PR:
Nothing special