Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TopLHEFilter #27794

Merged
merged 3 commits into from Aug 26, 2019
Merged

Add TopLHEFilter #27794

merged 3 commits into from Aug 26, 2019

Conversation

ohindrichs
Copy link

PR description:

This is a filter acting on the LHE output. It clusters the final LHE particles using the anti-kt jet algorithm. A cut on the minimum pT > 350 GeV is selected. This filter is a loose pre-selection of the AK8-jet pT > 650 GeV filter at particle level used in the production of TT_AK8HT650* samples. The pre-filter selects at LHE level 99.8% of the events with a jet of pT > 650 GeV at particle level, while only 3% of the inclusive ttbar sample passes the filter. Therefore, the number of events that have to be showered before the filter decision is drastically reduced.

PR validation:

Tests have shown that this pre-filter reduces the the run time per event from ~1.3s to ~0.2s.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 19, 2019

A new Pull Request was created by @ohindrichs for CMSSW_10_2_X.

It involves the following packages:

GeneratorInterface/GenFilters

@alberto-sanchez, @cmsbuild, @qliphy, @agrohsje, @efeyazgan can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@alberto-sanchez
Copy link
Member

@ohindrichs Is there any PR in master for this?

@ohindrichs
Copy link
Author

@alberto-sanchez No, should I make a PR in master for this? I did not test this.

@alberto-sanchez
Copy link
Member

@ohindrichs yes, make a pr for master.

@alberto-sanchez
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 19, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2076/console Started: 2019/08/19 23:31

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-536139/2076/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007468
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007277
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@srimanob
Copy link
Contributor

Is this specific to TOP, or for jet in general?
If it's latter case, should the module name be more general, like JetLHEFilter?
@alberto-sanchez @ohindrichs @qliphy

@franzoni franzoni mentioned this pull request Aug 20, 2019
@cmsbuild
Copy link
Contributor

Pull request #27794 was updated. @alberto-sanchez, @cmsbuild, @qliphy, @agrohsje, @efeyazgan can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #27794 was updated. @alberto-sanchez, @cmsbuild, @qliphy, @agrohsje, @efeyazgan can you please check and sign again.

@qliphy
Copy link
Contributor

qliphy commented Aug 21, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 21, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2097/console Started: 2019/08/21 08:55

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-536139/2097/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007468
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007275
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@alberto-sanchez
Copy link
Member

@ohindrichs please propagate the latest commit to master and 10_6

@ohindrichs
Copy link
Author

@alberto-sanchez master and 10_6 have been updated to the latest version

@alberto-sanchez
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0920e9c into cms-sw:CMSSW_10_2_X Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants