Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-hcx217 Move remaining geometry parameters for SIM step to HcalSimulationParameters #27803

Merged
merged 2 commits into from Aug 27, 2019

Conversation

bsunanda
Copy link
Contributor

PR description:

In the process of removing dependence of CompactView in the SIM step of HCAL, a few more variables are extracted and put in the object HcalSimulationParameters

PR validation:

Tested with standard runTheMatrix workflows

if this PR is a backport please specify the original PR:

Nothing special

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27803/11503

  • This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27803/11504

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

CondFormats/GeometryObjects
Geometry/HcalCommonData

@civanch, @Dr15Jones, @cvuosalo, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @franzoni, @tocheng, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 19, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2074/console Started: 2019/08/19 21:32

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df3b67/2074/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939508
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2939166
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 142 log files, 14 edm output root files, 34 DQM output files

@@ -18,6 +18,14 @@ class HcalSimulationParameters {
std::vector<int> pmtLeft_;
std::vector<int> pmtFiberLeft_;

std::vector<int> hfLevels_;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda
please make sure the evolution of the CondFormats class ( persistent type ) is limited to the pre* series. Once we have the 11_0_0, we won't be able to change the class any longer.

@bsunanda
Copy link
Contributor Author

@ggovi OK. I do not foresee to change it further. This covers all the usage of HCAL as foreseen in simulation till date

@cvuosalo
Copy link
Contributor

+1

@bsunanda
Copy link
Contributor Author

@ggovi @christopheralanwest @tocheng @tlampen @pohsun Please check and sign this PR

@bsunanda
Copy link
Contributor Author

@ggovi @christopheralanwest @tocheng @tlampen @pohsun Ping you once again

@pohsun
Copy link

pohsun commented Aug 26, 2019

+1

@bsunanda
Copy link
Contributor Author

@ggovi Please approve this PR

@ggovi
Copy link
Contributor

ggovi commented Aug 27, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bcfbd8e into cms-sw:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants