New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-hcx217 Move remaining geometry parameters for SIM step to HcalSimulationParameters #27803
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27803/11503
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27803/11504
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: CondFormats/GeometryObjects @civanch, @Dr15Jones, @cvuosalo, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @franzoni, @tocheng, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@@ -18,6 +18,14 @@ class HcalSimulationParameters { | |||
std::vector<int> pmtLeft_; | |||
std::vector<int> pmtFiberLeft_; | |||
|
|||
std::vector<int> hfLevels_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsunanda
please make sure the evolution of the CondFormats class ( persistent type ) is limited to the pre* series. Once we have the 11_0_0, we won't be able to change the class any longer.
@ggovi OK. I do not foresee to change it further. This covers all the usage of HCAL as foreseen in simulation till date |
+1 |
@ggovi @christopheralanwest @tocheng @tlampen @pohsun Please check and sign this PR |
@ggovi @christopheralanwest @tocheng @tlampen @pohsun Ping you once again |
+1 |
@ggovi Please approve this PR |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
In the process of removing dependence of CompactView in the SIM step of HCAL, a few more variables are extracted and put in the object HcalSimulationParameters
PR validation:
Tested with standard runTheMatrix workflows
if this PR is a backport please specify the original PR:
Nothing special