New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add customized NanoAOD content for JetMET JERC studies #27826
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27826/11550
|
A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master. It involves the following packages: PhysicsTools/NanoAOD @cmsbuild, @santocch, @fgolf, @peruzzim can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
FYI @ahinzmann @camclean @lathomas (sorry, don't know all usernames) |
Yes, as discussed also with @clelange, a very large part of the added file contains generic setup functions to build additional jet collections. They should go in a JME software area, leaving only the parts that customize NanoAOD configuration in the added file. The form of a function customizing the process seems adequate to me, we can discuss whether to also add a modifier to allow for activating it in a more robust way from the cmsDriver command line. |
@alefisico We were wondering whether with the help of JetToolBox we can significantly shorten the config, e.g. by making use of what is the equivalent of addGenJetCollection and addRecoJetCollection in JetToolBox. |
@clelange I think so, but I would need to test it first. |
@alefisico Yes, that would mean that JetToolBox would need to be integrated into CMSSW. I guess this won't happen on the timescale that we intend for this PR (and we should discuss somewhere else whether this is what we would want). |
In the beginning we had the jet toolbox in CMSSW but it became a nightmare to put in new features. We needed more flexibility. I agree that moving some functions into CMSSW would be better. This should probably go into PhysicsTools/PatAlgos somewhere. |
@nurfikri89 I think it makes sense to move those two functions to PhysicsTools/PatAlgos/python, e.g. a new file that could be called |
@clelange Yes, I can do it. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27826/11630
|
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
@nurfikri89 Can you backport this to 10_6_X? |
@ahinzmann Sure. Will do this now. |
@ahinzmann @clelange Backport to 10_6_X is #28052. |
Backport of #27826 (Add customized NanoAOD content for JetMET JERC studies)
For customized NanoAOD production for JetMET jet energy calibration. The script adds a few additional variables for AK4PFCHS and AK8PFPUPPI jets which are not available in the latest nanoAOD production (v5). It saves additional (reco & gen) jet collections that are available in MiniAODs and also jet collections that are not available in MiniAODs by building the jet collections first. These collections are the required input for jet energy calibration and the customized NanoAOD production is first step in the workflow to automate the jet energy calibration. This script needs to be backported to 10_6_X, once merged, for the ultra legacy campaigns.
A few questions:
The addGenJetCollection and addRecoJetCollection functions mix NanoAOD content and jet collection building. Should they be split into two parts, and if so, where should the non-NanoAOD related one be put?