Fix gcc9 warning in EventFilter/SiStripRawToDigi #27846
Conversation
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27846/11584
|
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages: EventFilter/SiStripRawToDigi @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| @@ -845,6 +845,7 @@ namespace sistrip { | |||
| case READOUT_MODE_SCOPE: | |||
| //scope mode is always real | |||
| setReadoutModeBits(readoutMode); | |||
| [[fallthrough]]; | |||
There was a problem hiding this comment.
It looks like there is some odd logic behind...
As it is now, all case's but the default one foresee
setReadoutModeBits(readoutMode);and therefore one could simplier remove L846, L847, L848, L862, L863 (and at this point even L865).
Could you please confirm that this is indeed the intended behaviour @OlivierBondu @alesaggio ?
There was a problem hiding this comment.
@pieterdavid FYI
@perrotta, Olivier has left CMS, please update the list of reco contact for strips accordingly.
There was a problem hiding this comment.
@pieterdavid FYI
@perrotta, Olivier has left CMS, please update the list of reco contact for strips accordingly.
Done in https://twiki.cern.ch/twiki/bin/view/CMS/RecoContacts
There was a problem hiding this comment.
This simplification should be correct and safe indeed.
|
@mrodozov , given #27846 (comment) and #27846 (comment), please update this PR by simply removing L846-847-848, L862-863, L865 |
|
The code-checks are being triggered in jenkins. |
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27846/11689
|
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Fix gcc9 warning in EventFilter/SiStripRawToDigi
PR validation:
Builds without the warning