[PPS] Removed static_cast in diamond raw-to-digi unpacker

[forthommel]

PR description:

This PR replaces a static_cast of plain TOTEM-like VFAT frames into DiamondVFATFrame by simple free-function accessors, following the prescription in #27860.

Also, new pps namespace (with nested sub-spaces) is introduced in this package to gradually replace the various ctpps... scopes found here and there.

PR validation:

Code compiles and runs successfully over a few backed up t0streamer streams. Produces exactly the same output as for the baseline.

if this PR is a backport please specify the original PR: N/A

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27873/11640

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @forthommel (Laurent Forthomme) for master.

It involves the following packages:

EventFilter/CTPPSRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @jan-kaspar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2195/console Started: 2019/08/26 23:07

[cmsbuild]

+1
Tested at: f9e72ed
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90c5ca/2195/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90c5ca/2195/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939166
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27873/11686

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #27873 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2245/console Started: 2019/08/28 23:18

[cmsbuild]

+1
Tested at: fcc4123
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90c5ca/2245/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90c5ca/2245/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939166
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[slava77]

+1

for #27873 fcc4123

• code changes are in line with the PR description and the follow up review; except for the part related to the issue in Improper cast in CTPPSRawToDigi #27860 (which is also somewhat technical), the changes are technical/code style.
• jenkins tests pass and comparisons with the baseline show no differences.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1