Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clang headers location and changed interfaces #27877

Merged
merged 2 commits into from Aug 29, 2019

Conversation

cmsbuild
Copy link
Contributor

backport of #27663

PR description:

Adjusting to llvm8 interfaces

PR validation:

It compiles

if this PR is a backport please specify the original PR:

@cmsbuild
Copy link
Contributor Author

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Aug 27, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5146
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2204/console Started: 2019/08/27 09:19

@cmsbuild
Copy link
Contributor Author

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27877/11648

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Aug 27, 2019

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

Utilities/StaticAnalyzers

@smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor Author

+1
Tested at: f88f67c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8612c8/2204/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8612c8/2204/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8612c8/2204/git-merge-result

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8612c8/2204/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939508
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2939162
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

@kpedro88 , this should also go in with llvm 8.0 update.

@smuzaffar
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

thanks @smuzaffar

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9588b32 into master Aug 29, 2019
@smuzaffar smuzaffar deleted the backport-master-27663 branch November 18, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants