Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TTI beam spot from 'Gauss' to 'HLLHC' #2790

Merged
merged 2 commits into from Mar 10, 2014

Conversation

mark-grimes
Copy link

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Change TTI beam spot from 'Gauss' to 'HLLHC'

It involves the following packages:

Configuration/PyReleaseValidation

@nclopezo, @vlimant, @cmsbuild, @franzoni, @Degano, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

Ping @boudoul
Thought I should bring this to your attention in case it conflicts with anything you're doing. I will test and merge (if it passes) in a minute.

@boudoul
Copy link
Contributor

boudoul commented Mar 10, 2014

thanks Mark, that's ok!

@mark-grimes
Copy link
Author

All other test are as before. The TTI test (12800) now fails in step 2:

----- Begin Fatal Exception 10-Mar-2014 15:58:57 CET-----------------------
An exception of category 'Conditions mismatch' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
Requested conditions of type HcalMCParams for cell (0x49180c30) (HF 3,48,1) got conditions for cell (0x48007329) (HF 38,41,1)
----- End Fatal Exception -------------------------------------------------

I don't understand how this change could cause that. I'll double check and make sure I'm not doing anything stupid with the integration.

@andersonjacob
Copy link
Contributor

Hi Mark,

This is an interesting message. There isn't an HF 3 nor has there ever
been or will there probably ever be one. I suspect this is a problem with
a SLHC flag being set or not set correctly in a customization.

Jake

On Mon, Mar 10, 2014 at 10:10 AM, Mark Grimes notifications@github.comwrote:

All other test are as before. The TTI test (12800) now fails in step 2:

----- Begin Fatal Exception 10-Mar-2014 15:58:57 CET-----------------------
An exception of category 'Conditions mismatch' occurred while
[0] Processing run: 1 lumi: 1 event: 1
[1] Running path 'digitisation_step'
[2] Calling event method for module MixingModule/'mix'
Exception Message:
Requested conditions of type HcalMCParams for cell (0x49180c30) (HF 3,48,1) got conditions for cell (0x48007329) (HF 38,41,1)
----- End Fatal Exception -------------------------------------------------

I don't understand how this change could cause that. I'll double check and
make sure I'm not doing anything stupid with the integration.

Reply to this email directly or view it on GitHubhttps://github.com//pull/2790#issuecomment-37192584
.

@mark-grimes
Copy link
Author

Found the problem. Copy and paste screw up didn't apply the upgrade customisation. Thanks Jake. I'll apply a fix in a minute.

@cmsbuild
Copy link
Contributor

Pull request #2790 was updated. @nclopezo, @vlimant, @cmsbuild, @franzoni, @Degano, @davidlange6 can you please check and sign again.

@mark-grimes
Copy link
Author

merge

Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800, 12000, 12800 and 13000 pass all steps.
Tests 12200, 12400, 12600, 13200 and 13400 fail in step 2 with known errors.

cmsbuild added a commit that referenced this pull request Mar 10, 2014
Change TTI beam spot from 'Gauss' to 'HLLHC'
@cmsbuild cmsbuild merged commit b55039e into cms-sw:CMSSW_6_2_X_SLHC Mar 10, 2014
@mark-grimes mark-grimes deleted the changeTTIBeamSpot branch March 13, 2014 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants