Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APE tool: Trend plots, some minor fixes: Backport of #27656 #27936

Merged
merged 1 commit into from Sep 19, 2019

Conversation

mteroerd
Copy link
Contributor

@mteroerd mteroerd commented Sep 5, 2019

Backport of #27656

PR description:

This PR is the summary of some changes that were made to the APE estimation tool during the UL2017 and UL2018 campaigns.

It includes:

  • a tool for trend plots (hence, the data/ folder and additions in test/plottingTools)
  • a way to change marker styles and colors for result plots
  • a way to add the number of hits in a sector to result plots
  • fix to a small typo in test/batch/startSkim.py
  • fix to the wrong ideal alignment being loaded in test/cfgTemplate/apeEstimator_cfg.py
  • additional functionality for test/autoSubmitter:
    • Basic support for submitting to condor "CAF queue".
    • Protection against cases where the condor scheduler is unavailable when submitting jobs which used to cause crashes. Now, in this case the submission is retried after some waiting time until it works.
    • Support for running multiple threads to handle measurements in case of large campaigns. Before, it happened that condor jobs (that do the track refits) of measurements finished while another measurement was being handled, so that there was some delay before these measurements were handled, which piled up to longer delay when doing many measurements.
    • Some minor changes like putting some functions into helper.py and introducing new shortcuts for convenience.

PR Validation:

The validation happened while using the tool. Since no changes were made that could affect the APE results themselves, everything was transparent.

if this PR is a backport please specify the original PR:

Backport of #27656

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2019

A new Pull Request was created by @mteroerd (Marius Teroerde) for CMSSW_10_6_X.

It involves the following packages:

Alignment/APEEstimation

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @tocheng, @adewit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@tlampen
Copy link
Contributor

tlampen commented Sep 6, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2395/console Started: 2019/09/06 11:07

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc1090/2395/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211049
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3210713
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@pohsun
Copy link

pohsun commented Sep 12, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@mteroerd which is the purpose of this backport? For future reference? The usage of the package itself was done in master I expect

@mteroerd
Copy link
Contributor Author

@fabiocos I was told that the Alignment+Validation of UL2016 ReReco is done on 10_6_0, which is why it would be useful to have the updated code for that release.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ca3c6e4 into cms-sw:CMSSW_10_6_X Sep 19, 2019
@mteroerd mteroerd deleted the ape_trend_backport branch December 6, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants