Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-sim45 Remove reference to G4DataQuestionaire #27943

Merged
merged 2 commits into from Sep 8, 2019

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Sep 5, 2019

PR description:

This reference is not needed in current Geant4 version used and the sequence G4DataQuestionaire.hh will be dropped in future Geant4 versions

PR validation:

Tested with the standard matrix

if this PR is a backport please specify the original PR:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2019

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27943/11790

  • This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27943/11791

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2019

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

SimG4Core/CustomPhysics
SimG4Core/GFlash
SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Sep 6, 2019

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2390/console Started: 2019/09/06 04:28

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e8e0d/2390/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2955796
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2955454
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@civanch
Copy link
Contributor

civanch commented Sep 6, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@civanch
Copy link
Contributor

civanch commented Sep 6, 2019

@fabiocos, this PR is simple but necessary step for new Geant4. Removed code is obsolete and useless.

@fabiocos
Copy link
Contributor

fabiocos commented Sep 8, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants