Access best/second A/CLCT through public function in CSC TP emulator

[dildick]

PR description:

This PR replaces the usage of public member variables (e.g. bestALCT) to public member functions (e.g. getBestALCT()) in CSC motherboard classes - an artifact of the legacy CSC TP emulator code. I largely relied on sed to make the (trivial) changes:

sed -i 's/->bestALCT\[/->getBestALCT(/g' *.cc
sed -i 's/->bestCLCT\[/->getBestCLCT(/g' *.cc
sed -i 's/->secondALCT\[/->getSecondALCT(/g' *.cc
sed -i 's/->secondCLCT\[/->getSecondCLCT(/g' *.cc
sed -i 's/(bx_alct\]/(bx_alct)/g' *.cc
sed -i 's/(bx_clct\]/(bx_clct)/g' *.cc

Update: upon further inspection, it appears that the CLCT BX shift in PR #24402 was incomplete. The public variables bestCLCT and secondCLCT would return CLCTs at central BX7. The new public functions getBestCLCT() and getSecondCLCT() return CLCTs with central BX8. However, the CLCT readout remains unchanged, i.e. it will produce produce the CLCT digi collection with a central BX of 7. Also, this change won't have an effect on the LCT reconstruction efficiency, since the ALCT-CLCT BX matching window is at least 3 to 7 BX wide.

PR validation:

I tested it with WF 22034.0

@tahuang1991

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27956/11820

• This PR adds an extra 68KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27956/11826

• This PR adds an extra 68KB to repository

[cmsbuild]

Pull request #27956 was updated. @cmsbuild, @rekovic, @benkrikler can you please check and sign again.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27956/11828

• This PR adds an extra 76KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/CSCTriggerPrimitives/src/CSCGEMMotherboard.cc modified in PR(s): Fix mix-up between the physical and the trigger chamber number in upgrade CSC motherboard #27958

[dildick]

@fabiocos Can you please merge this PR? Thanks.

[dildick]

@fabiocos Can you please merge this PR?

[fabiocos]

code-checks

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27956/12144

• This PR adds an extra 80KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/CSCTriggerPrimitives/interface/CSCAnodeLCTProcessor.h modified in PR(s): Move CSC local trigger patterns to pattern bank #28044
  • File L1Trigger/CSCTriggerPrimitives/interface/CSCCathodeLCTProcessor.h modified in PR(s): Move CSC local trigger patterns to pattern bank #28044
  • File L1Trigger/CSCTriggerPrimitives/interface/CSCGEMMotherboard.h modified in PR(s): Move CSC local trigger patterns to pattern bank #28044
  • File L1Trigger/CSCTriggerPrimitives/interface/CSCMotherboard.h modified in PR(s): Move CSC local trigger patterns to pattern bank #28044
  • File L1Trigger/CSCTriggerPrimitives/src/CSCAnodeLCTProcessor.cc modified in PR(s): Move CSC local trigger patterns to pattern bank #28044
  • File L1Trigger/CSCTriggerPrimitives/src/CSCCathodeLCTProcessor.cc modified in PR(s): Move CSC local trigger patterns to pattern bank #28044
  • File L1Trigger/CSCTriggerPrimitives/src/CSCGEMMotherboard.cc modified in PR(s): Move CSC local trigger patterns to pattern bank #28044
  • File L1Trigger/CSCTriggerPrimitives/src/CSCGEMMotherboardME11.cc modified in PR(s): Move CSC local trigger patterns to pattern bank #28044
  • File L1Trigger/CSCTriggerPrimitives/src/CSCGEMMotherboardME21.cc modified in PR(s): Move CSC local trigger patterns to pattern bank #28044
  • File L1Trigger/CSCTriggerPrimitives/src/CSCMotherboard.cc modified in PR(s): Move CSC local trigger patterns to pattern bank #28044
  • File L1Trigger/CSCTriggerPrimitives/src/CSCMotherboardME11.cc modified in PR(s): Move CSC local trigger patterns to pattern bank #28044
  • File L1Trigger/CSCTriggerPrimitives/src/CSCUpgradeMotherboard.cc modified in PR(s): Move CSC local trigger patterns to pattern bank #28044, Move LCTContainer to separate file #28070

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2800/console Started: 2019/10/05 19:28

[cmsbuild]

+1
Tested at: cedbb6f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2041eb/2800/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2041eb/2800/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2961049
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960706
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[fabiocos]

+1