New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GE2/1 LUTs for GE2/1-ME2/1 integrated local trigger #27957
Update GE2/1 LUTs for GE2/1-ME2/1 integrated local trigger #27957
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27957/11821
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: L1Trigger/CSCTriggerPrimitives @cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@rekovic Do you have any more comments? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@fabiocos Correct. This only affects Phase-2. I think there would have to be muons flying exactly into those regions of ME2/1 where the LCT efficiency is reduced due to a lower high-voltage to see an effect. Because that is where Cathode LCTs are typically lost. If I'm not mistaken, this reduced high-voltage region is about 10-15% of ME21/, corresponding to a delta eta between 0.1 and 0.2. The tests are limited in statistics. I tested these changes on several thousand muons with |eta| between 1.6 and 2.4. |
+1 |
PR description:
This PR updates a few LUTs for GE2/1-ME2/1 in the Phase-2 CSC local trigger. GE2/1 geometry changed some time ago from 12 to 8 eta partitions. The out-of-data LUTs caused significant drops in efficiency for the GE2/1-ME2/1 integrated trigger stubs.
PR validation:
I tested this PR with a Phase-2 PU0 single muon sample to make sure that ALCTs were properly matched to GEM pads.