Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GE2/1 LUTs for GE2/1-ME2/1 integrated local trigger #27957

Merged
merged 2 commits into from Sep 26, 2019
Merged

Update GE2/1 LUTs for GE2/1-ME2/1 integrated local trigger #27957

merged 2 commits into from Sep 26, 2019

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Sep 9, 2019

PR description:

This PR updates a few LUTs for GE2/1-ME2/1 in the Phase-2 CSC local trigger. GE2/1 geometry changed some time ago from 12 to 8 eta partitions. The out-of-data LUTs caused significant drops in efficiency for the GE2/1-ME2/1 integrated trigger stubs.

PR validation:

I tested this PR with a Phase-2 PU0 single muon sample to make sure that ALCTs were properly matched to GEM pads.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27957/11821

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@dildick dildick marked this pull request as ready for review September 9, 2019 22:44
@dildick dildick changed the title Update GE2/1 LUTs Update GE2/1 LUTs for GE2/1-ME2/1 integrated local trigger Sep 10, 2019
@rekovic
Copy link
Contributor

rekovic commented Sep 10, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 10, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2444/console Started: 2019/09/10 11:54

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-294fab/2444/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2957224
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2956882
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@dildick
Copy link
Contributor Author

dildick commented Sep 20, 2019

@rekovic Do you have any more comments?

@rekovic
Copy link
Contributor

rekovic commented Sep 25, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@dildick @rekovic as far as I understand this is supposed to affect only Phase2, a not previous setups, am I correct? The PR test does not show any change, I may guess because of the limited statistics

@dildick
Copy link
Contributor Author

dildick commented Sep 26, 2019

@fabiocos Correct. This only affects Phase-2.

I think there would have to be muons flying exactly into those regions of ME2/1 where the LCT efficiency is reduced due to a lower high-voltage to see an effect. Because that is where Cathode LCTs are typically lost. If I'm not mistaken, this reduced high-voltage region is about 10-15% of ME21/, corresponding to a delta eta between 0.1 and 0.2. The tests are limited in statistics. I tested these changes on several thousand muons with |eta| between 1.6 and 2.4.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 210f8a9 into cms-sw:master Sep 26, 2019
@dildick dildick deleted the from-CMSSW_11_0_X_2019-09-08-2300-update-GE21-LUTs branch October 3, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants