Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reintroduce missing lseek() for header-less files #27982

Merged
merged 1 commit into from Sep 16, 2019

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 12, 2019

PR description:

Fix a problem encountered reading legacy FED RAW data files in "file list" mode.

PR validation:

Reading legacy files now works.

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 12, 2019

Thanks to @smorovic for the fix.

@cmsbuild cmsbuild changed the base branch from CMSSW_11_0_X to master September 12, 2019 15:27
@cmsbuild
Copy link
Contributor

@fwyzard, CMSSW_11_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild cmsbuild added this to the CMSSW_11_0_X milestone Sep 12, 2019
@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 12, 2019

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27982/11873

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 12, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2502/console Started: 2019/09/12 17:45

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

EventFilter/Utilities

@perrotta, @mommsen, @cmsbuild, @emeschi, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c68d1/2502/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2957224
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2956881
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@slava77
Copy link
Contributor

slava77 commented Sep 14, 2019

+1

for #27982 361bb72

  • code changes are in online-specific code EventFilter/Utilities/src/EvFDaqDirector.cc, which is not in the reco responsibility (the package is shared with daq).
  • jenkins tests pass

@mommsen
Copy link
Contributor

mommsen commented Sep 16, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a5b4792 into cms-sw:master Sep 16, 2019
@fwyzard fwyzard deleted the fix_EvFDaqDirector branch May 14, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants