Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APV simulation in PreMixingSiStripWorker #28028

Merged
merged 2 commits into from Sep 26, 2019

Conversation

pieterdavid
Copy link
Contributor

PR description:

This adds the new APV simulation from #27823 also to the PreMixingSiStripWorker, which is used instead of the SiStripDigitizer when premixing is used.
It goes together with the configuration changes in #28024 .

PR validation:

by @mmusich, see #28024 : when enabling the APV simulation at the data mixing step (and not when making the premixing pileup library) the cluster charge distribution matches with the non-premixing scenario.

CC: @EmyrClement

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28028/11952

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pieterdavid (Pieter David) for master.

It involves the following packages:

SimTracker/SiStripDigitizer

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@echabert, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @prolay, @ebrondol, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28028/11956

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #28028 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

const auto it = std::find_if(
std::begin(ps), std::end(ps), [](const PileupSummaryInfo& bxps) { return bxps.getBunchCrossing() == 0; });
if (it != std::begin(ps)) {
nTruePU = it->getTrueNumInteractions();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the main difference with the SiStripDigitizer implementation: is this the correct way to get the average number of interactions (Poisson parameter) for the in-time bunch-crossing? The original code is here: https://github.com/cms-sw/cmssw/blob/master/SimTracker/SiStripDigitizer/plugins/SiStripDigitizerAlgorithm.cc#L249-L281 but the same object is not available here (or I did not immediately find a way to get it)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pieterdavid In short: yes, it is.

(the ps is the vector<PileupSummaryInfo> from the premixed pileup event)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makortel thanks for confirming!

@mmusich
Copy link
Contributor

mmusich commented Sep 20, 2019

For the record, I attach here couple of plots obtained running 200 events using the wfs introduced in #28024 using the release and the changes proposed here:
image

image

(black is 25202.1, red is 250202.2 in the two cases).
The discrepancy between standard mixing and pre-mixing is recovered.

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 21, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2606/console Started: 2019/09/21 17:28

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 24, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) #28024
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2645/console Started: 2019/09/24 14:48

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14dd72/2645/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-14dd72/1325.9_TTbar_13+TTbar_13+DIGIUP15APVSimu+RECOUP15+HARVESTUP15+ALCATTUP15
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-14dd72/250202.2_TTbar_13+TTbar_13+DIGIPRMXUP15APVSimu_PU25+RECOPRMXUP15_PU25+HARVESTUP15_PU25
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-14dd72/250202.3_TTbar_13+TTbar_13+PREMIXUP15_PU25+DIGIPRMXLOCALUP15APVSimu_PU25+RECOPRMXUP15_PU25+HARVESTUP15_PU25
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-14dd72/25202.1_TTbar_13+TTbar_13+DIGIUP15APVSimu_PU25+RECOUP15_PU25+HARVESTUP15_PU25

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2958092
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2957750
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@civanch
Copy link
Contributor

civanch commented Sep 24, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

ready to enter together #28024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants