New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move away from boost::uint and boost::int in favor of C++11 classes #28060
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28060/11993
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28060/11994
|
+1 |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
+1
|
+1 |
+1 |
+upgrade |
merge |
PR description:
removed usage of boost::uint<8,16,32,64>_t in favor of uint<8,16,32,64>_t
removed usage of boost::int<8,16,32,64>_t in favor of int<8,16,32,64>_t
removed include boost/cstdint.hpp and added include cstdint in an file modified.
Many other CMSSW files should also include based on their existing usage of these types. Fixing that is not a part of this pull request
PR validation:
compiles and runs tests in runTheMatrix - should be transparent.