Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move away from boost::uint and boost::int in favor of C++11 classes #28060

Merged
merged 2 commits into from Sep 25, 2019

Conversation

davidlange6
Copy link
Contributor

PR description:

removed usage of boost::uint<8,16,32,64>_t in favor of uint<8,16,32,64>_t
removed usage of boost::int<8,16,32,64>_t in favor of int<8,16,32,64>_t
removed include boost/cstdint.hpp and added include cstdint in an file modified.

Many other CMSSW files should also include based on their existing usage of these types. Fixing that is not a part of this pull request

PR validation:

compiles and runs tests in runTheMatrix - should be transparent.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28060/11993

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28060/11994

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a355f4/2638/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2958092
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2957750
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@jfernan2
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Sep 24, 2019

+1

@perrotta
Copy link
Contributor

+1

  • Technical
  • Changes in reco-related classes correspond to what declared in the PR description
  • Jenkins tests pass

@fabiocos
Copy link
Contributor

fabiocos commented Sep 25, 2019

@ggovi @christopheralanwest @rekovic @kpedro88 @pohsun @santocch please check, I will merge this PR for the next IB

@tlampen
Copy link
Contributor

tlampen commented Sep 25, 2019

+1

@santocch
Copy link

+1

@kpedro88
Copy link
Contributor

+upgrade
thanks @davidlange6 !

@fabiocos
Copy link
Contributor

+1

@ggovi @rekovic please check and possibly comment

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 911a639 into cms-sw:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment