Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nano AOD step added for 2016 standard and pileup relvals #28061

Merged
merged 3 commits into from Sep 29, 2019

Conversation

ahmad3213
Copy link
Contributor

@ahmad3213 ahmad3213 commented Sep 24, 2019

PR description:

Nano AOD step added to Standard (2016)
runTheMatrix.py --what standard -l 1338.0,1325.0,1311.0,1330.0,1329.0,1331.0,1317.0,1320.0,1321.0,1318.0,1332.0
and For Pileup (2016)
runTheMatrix.py --what pileup -l 25200,25202,25203,25205,25206,25209.0

PR validation:

1: Tested locally for one standard relvals
runTheMatrix.py --what standard -l 1338.0 t 4 -b 'fullsim_noPU_2016' --noCaf --wm init

2: Tested locally for one Pileup relval
runTheMatrix.py --what pileup -l 25200 -t 4 -b 'fullsim_PU_2016' --noCaf --wm init

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28061/11997

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ahmad3213 (Muhammad Ahmad ) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @pgunnell, @cmsbuild, @kpedro88, @zhenhu can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@chayanit
Copy link

please test workflow 1338.0,1325.0,1311.0,1330.0,1329.0,1331.0,1317.0,1320.0,1321.0,1318.0,1332.0,25200,25202,25203,25205,25206,25209.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 24, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2640/console Started: 2019/09/24 13:20

@cmsbuild
Copy link
Contributor

-1

Tested at: f396c99

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8be4/2640/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
1311.0 step6

runTheMatrix-results/1311.0_MinBias_13+MinBias_13+DIGIUP15+RECOMINUP15+HARVESTMINUP15+ALCAMINUP15+NANOUP15/step6_MinBias_13+MinBias_13+DIGIUP15+RECOMINUP15+HARVESTMINUP15+ALCAMINUP15+NANOUP15.log

1317.0 step5
runTheMatrix-results/1317.0_SingleElectronPt35_UP15+SingleElectronPt35_UP15+DIGIUP15+RECOUP15+HARVESTUP15+NANOUP15/step5_SingleElectronPt35_UP15+SingleElectronPt35_UP15+DIGIUP15+RECOUP15+HARVESTUP15+NANOUP15.log

1318.0 step5
runTheMatrix-results/1318.0_SingleGammaPt10_UP15+SingleGammaPt10_UP15+DIGIUP15+RECOUP15+HARVESTUP15+NANOUP15/step5_SingleGammaPt10_UP15+SingleGammaPt10_UP15+DIGIUP15+RECOUP15+HARVESTUP15+NANOUP15.log

1325.0 step6
runTheMatrix-results/1325.0_TTbar_13+TTbar_13+DIGIUP15+RECOUP15+HARVESTUP15+ALCATTUP15+NANOUP15/step6_TTbar_13+TTbar_13+DIGIUP15+RECOUP15+HARVESTUP15+ALCATTUP15+NANOUP15.log

1329.0 step5
runTheMatrix-results/1329.0_ZEE_13+ZEE_13+DIGIUP15+RECOUP15_L1TEgDQM+HARVESTUP15_L1TEgDQM+NANOUP15/step5_ZEE_13+ZEE_13+DIGIUP15+RECOUP15_L1TEgDQM+HARVESTUP15_L1TEgDQM+NANOUP15.log

1330.0 step5
runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15/step5_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15.log

1331.0 step5
runTheMatrix-results/1331.0_ZTT_13+ZTT_13+DIGIUP15+RECOUP15+HARVESTUP15+NANOUP15/step5_ZTT_13+ZTT_13+DIGIUP15+RECOUP15+HARVESTUP15+NANOUP15.log

1338.0 step5
runTheMatrix-results/1338.0_QCD_FlatPt_15_3000HS_13+QCD_FlatPt_15_3000HS_13+DIGIUP15+RECOUP15+HARVESTUP15+NANOUP15/step5_QCD_FlatPt_15_3000HS_13+QCD_FlatPt_15_3000HS_13+DIGIUP15+RECOUP15+HARVESTUP15+NANOUP15.log

25200.0 step5
runTheMatrix-results/25200.0_ZEE_13+ZEE_13+DIGIUP15_PU25+RECOUP15_PU25_L1TEgDQM+HARVESTUP15_PU25_L1TEgDQM+NANOUP15_PU25/step5_ZEE_13+ZEE_13+DIGIUP15_PU25+RECOUP15_PU25_L1TEgDQM+HARVESTUP15_PU25_L1TEgDQM+NANOUP15_PU25.log

25206.0 step5
runTheMatrix-results/25206.0_ZMM_13+ZMM_13+DIGIUP15_PU25+RECOUP15_PU25_L1TMuDQM+HARVESTUP15_PU25_L1TMuDQM+NANOUP15_PU25/step5_ZMM_13+ZMM_13+DIGIUP15_PU25+RECOUP15_PU25_L1TMuDQM+HARVESTUP15_PU25_L1TMuDQM+NANOUP15_PU25.log

25203.0 step5
runTheMatrix-results/25203.0_H125GGgluonfusion_13+H125GGgluonfusion_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step5_H125GGgluonfusion_13+H125GGgluonfusion_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

25202.0 step5
runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step5_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

25205.0 step5
runTheMatrix-results/25205.0_ZTT_13+ZTT_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step5_ZTT_13+ZTT_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

25209.0 step5
runTheMatrix-results/25209.0_QCD_FlatPt_15_3000HS_13+QCD_FlatPt_15_3000HS_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step5_QCD_FlatPt_15_3000HS_13+QCD_FlatPt_15_3000HS_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@fabiocos
Copy link
Contributor

@chayanit @kpedro88 I'll take previous signatures as good

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28061/12061

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 27, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2710/console Started: 2019/09/27 23:02

@cmsbuild
Copy link
Contributor

Pull request #28061 was updated. @chayanit, @pgunnell, @cmsbuild, @kpedro88, @zhenhu can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8be4/2710/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-2e8be4/1311.0_MinBias_13+MinBias_13+DIGIUP15+RECOMINUP15+HARVESTMINUP15+ALCAMINUP15
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-2e8be4/1329.0_ZEE_13+ZEE_13+DIGIUP15+RECOUP15_L1TEgDQM+HARVESTUP15_L1TEgDQM+NANOUP15
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-2e8be4/1331.0_ZTT_13+ZTT_13+DIGIUP15+RECOUP15+HARVESTUP15+NANOUP15
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-2e8be4/25205.0_ZTT_13+ZTT_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2741018
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2740704
  • DQMHistoTests: Total skipped: 313
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 137 log files, 11 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@kpedro88 @chayanit it was already signed by you, I just adjusted a minor conflict, please have a look at it anyway

@cmsbuild cmsbuild merged commit f5b96f5 into cms-sw:master Sep 29, 2019
@kpedro88
Copy link
Contributor

+upgrade

@chayanit
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants