Enable pt-dependent JER-SF and phi-dependent JEC application in PAT #28096
Conversation
|
The code-checks are being triggered in jenkins. |
ahinzmann
changed the title
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28096/12089
|
|
A new Pull Request was created by @ahinzmann for master. It involves the following packages: JetMETCorrections/Modules @perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
ahinzmann
changed the title
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| # Input source | ||
| process.source = cms.Source("PoolSource", | ||
| fileNames = cms.untracked.vstring( | ||
| 'file:////afs/cern.ch/user/h/hinzmann/workspace/tmp/102D73A7-5B87-E611-936E-0CC47A1E0472.root', |
There was a problem hiding this comment.
private files from AFS should not be used in the released source code.
Please change to something available centrally.
| label = cms.untracked.string('AK4PFchs') | ||
| ), | ||
| ), | ||
| connect = cms.string('sqlite:Autumn18_V7_MC.db') |
There was a problem hiding this comment.
is this an extremely temporary solution?
Shouldn't the payloads be uploaded already to the DB, or is the expectation that this mechanism will always be done with a local db file?
Is this test file really needed in the release?
The SmearedPATJetProducer is apparently used in the standard workflows. So, to enable the new corrections one would ideally just need to run the standard PAT with a candidate GT.
There was a problem hiding this comment.
The main reason to provide this config was, to be able to test this before the global tag is available. It will come in a couple of days.
The SmearedPATJetProducer is only used for MET uncertainties in standard workflows, thus not the most direct test of it.
If the file is nevertheless not desired I can remove it?
There was a problem hiding this comment.
I think that a commented out variant provided as an example is OK
|
Can we please proceed more quickly with the preparation of this PR? It's needed for NanoAODv6 (and in general for analysis). @ahinzmann have you implemented the requested changes? |
|
yes, all changes are in |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
analysis-approved
fully-signed
and removed
analysis-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
cmsbuild
added
comparison-pending
tests-approved
and removed
comparison-available
tests-started
labels
|
Comparison is ready Comparison Summary:
|
|
+1 |
PR description:
Enable pt-dependent jet resolution scale factors in PAT. This is needed to apply Autumn18_V7 JER-SF, released last week.
Enable phi-dependent jet energy scale in PAT. This will be needed for 2018 JEC to deal with the HEM issue.
This PR has no impact with the current global tags in any release. However, it will enable using a new global tag (currently in the makings) with pt-dependent JER-SFs and later with phi-dependent JECs.
A test config to apply resolution smearing from a db file has been added under /test.
Here is an example db-file containing pt-dependent JER-SFs:
https://github.com/cms-jet/JRDatabase/blob/master/SQLiteFiles/Autumn18_V7_MC.db
PR validation:
Test config runs after inclusion of this PR. It was checked that this does not change the memory consumption, compared to using the old code with Autumn18_V1_MC.db (no pt-dependence).