Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nano AOD step added for pLHE samples #28102

Merged
merged 1 commit into from Oct 9, 2019
Merged

Nano AOD step added for pLHE samples #28102

merged 1 commit into from Oct 9, 2019

Conversation

ahmad3213
Copy link
Contributor

PR description:

Nano AOD step added to Standard pLHE relvals

runTheMatrix.py --what standard -l 1361.17, 1362.17, 1363.17,1361.18,1362.18,1363.18,1361.181,1370,1370.17, 1370.18

PR validation:

Tested by running locally following two relvals
runTheMatrix.py --what standard -l 1370, 1361.181 -t 8 -b 'fullsim_noPU_pLHE' --noCaf --wm init

@cmsbuild cmsbuild added this to the CMSSW_11_0_X milestone Oct 2, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28102/12102

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2019

A new Pull Request was created by @ahmad3213 (Muhammad Ahmad ) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @pgunnell, @cmsbuild, @kpedro88, @zhenhu can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28102/12146

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2019

Pull request #28102 was updated. @chayanit, @pgunnell, @cmsbuild, @kpedro88, @zhenhu can you please check and sign again.

@chayanit
Copy link

chayanit commented Oct 6, 2019

please test workflow 1361.17, 1362.17, 1363.17,1361.18,1362.18,1363.18,1361.181,1370,1370.17, 1370.18,1338.0,1325.0,1311.0,1330.0,1329.0,1331.0,1317.0,1320.0,1321.0,1318.0,1332.0,25200,25202,25203,25205,25206,25209.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2807/console Started: 2019/10/06 18:10

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2019

-1

Tested at: d236e9a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-269d35/2807/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2019

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

The code-checks are being triggered in jenkins.

@chayanit
Copy link

chayanit commented Oct 8, 2019

please test workflow 1361.17,1361.18,1361.181,1370,1338.0,1325.0,1311.0,1330.0,1329.0,1331.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28102/12169

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2834/console Started: 2019/10/08 12:59

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

Pull request #28102 was updated. @chayanit, @pgunnell, @cmsbuild, @kpedro88, @zhenhu can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

+1
Tested at: 8d99b37
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-269d35/2834/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

Comparison job queued.

@chayanit
Copy link

chayanit commented Oct 8, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-269d35/2834/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-269d35/1311.0_MinBias_13+MinBias_13+DIGIUP15+RECOMINUP15+HARVESTMINUP15+ALCAMINUP15
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-269d35/1329.0_ZEE_13+ZEE_13+DIGIUP15+RECOUP15_L1TEgDQM+HARVESTUP15_L1TEgDQM+NANOUP15
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-269d35/1331.0_ZTT_13+ZTT_13+DIGIUP15+RECOUP15+HARVESTUP15+NANOUP15
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-269d35/1361.17_GluGluHToZZTo4L_M125_Pow_py8_Evt_13UP17+GluGluHToZZTo4L_M125_Pow_py8_Evt_13UP17+DIGIUP17+RECOUP17+HARVESTUP17+NANOUP17
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-269d35/1361.181_GluGluHToZZTo4L_M125_Pow_py8_Evt_13UP18ml+GluGluHToZZTo4L_M125_Pow_py8_Evt_13UP18ml+DIGIUP18ml+RECOUP18ml+HARVESTUP18+NANOUP18ml
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-269d35/1361.18_GluGluHToZZTo4L_M125_Pow_py8_Evt_13UP18+GluGluHToZZTo4L_M125_Pow_py8_Evt_13UP18+DIGIUP18+RECOUP18+HARVESTUP18+NANOUP18
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-269d35/1370.0_GluGluHToGG_M125_Pow_MINLO_NNLOPS_py8_13+GluGluHToGG_M125_Pow_MINLO_NNLOPS_py8_13+Hadronizer_TuneCUETP8M1_13TeV_powhegEmissionVeto_2p_HToGG_M125_13+DIGIUP15+RECOUP15+HARVESTUP15+NANOUP15Had

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2961052
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2960710
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 9, 2019

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Oct 9, 2019

+1

@cmsbuild cmsbuild merged commit 5b63a71 into cms-sw:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiocos fabiocos fabiocos left review comments

@kpedro88 kpedro88 kpedro88 left review comments

@chayanit chayanit chayanit requested changes

Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed orp-approved pdmv-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_11_0_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ahmad3213 @cmsbuild @chayanit @kpedro88 @fabiocos