Make puppi algo better readable

[ahinzmann]

Make puppi algo better readable. Consistently use one ID for particles throughout the code.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28104/12104

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CommonTools/PileupAlgos/interface/PuppiAlgo.h modified in PR(s): Updating Puppiproducer to include fillDescriptions v2 #28020
  • File CommonTools/PileupAlgos/src/PuppiAlgo.cc modified in PR(s): Updating Puppiproducer to include fillDescriptions v2 #28020
  • File CommonTools/PileupAlgos/src/PuppiContainer.cc modified in PR(s): Simplify PUPPI Photon producer and change PUPPI isolation algo #27929, Updating Puppiproducer to include fillDescriptions v2 #28020

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28104/12104/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28104/12104/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28104/12105

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CommonTools/PileupAlgos/interface/PuppiAlgo.h modified in PR(s): Updating Puppiproducer to include fillDescriptions v2 #28020
  • File CommonTools/PileupAlgos/src/PuppiAlgo.cc modified in PR(s): Updating Puppiproducer to include fillDescriptions v2 #28020
  • File CommonTools/PileupAlgos/src/PuppiContainer.cc modified in PR(s): Simplify PUPPI Photon producer and change PUPPI isolation algo #27929, Updating Puppiproducer to include fillDescriptions v2 #28020

[cmsbuild]

A new Pull Request was created by @ahinzmann for master.

It involves the following packages:

CommonTools/PileupAlgos

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@jdolen, @rappoccio, @gkasieczka, @riga, @clelange this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

curiously enough, there is no overlap in the context lines with #27929

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2749/console Started: 2019/10/02 10:45

[cmsbuild]

+1
Tested at: 062fa20
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c5055b/2749/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c5055b/2749/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2956833
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2956491
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[slava77]

+1

for #28104 062fa20

• somewhat technical cleanup
• jenkins tests pass and comparisons with the baseline show no differences

[fabiocos]

it looks like there is no real conflict with other open PRs, so it may enter

[fabiocos]

+1

[fabiocos]

merge

@santocch please have a look

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.